[runtime-spec VOTE] tag 19a93a2 as v1.0.0-rc3 (closes Wed Dec 14 16:38:00 UTC 2016)

[Vincent Batts]

Hey y'all,

It's been since 2016-09-08 that v1.0.0-rc2 was commited, and since then there has been 49 pull requests merged.

https://github.com/opencontainers/runtime-spec/pull/642 is the PR that includes the commit to be tagged

If you agree reply with LGTM.
If you disagree reply with REJECT and your reasoning.

vb

[W. Trevor King]

I've pushed a ChangeLog update [1] if you want to pull that in. Above
the fold for this bump:

Additions:

* config: Add support for Windows-based containers (#565, #573)
* config: Add process.consoleSize (#563)
* config: Explicitly allow unknown extensions and document
annotations key conventions (#510)
* config: Define mounts entries for Solaris (#588)

Removals and increased restrictions:

* config: Require absolute paths for mount destinations (#609)
* config-linux: Require absolute path for maskedPaths and
readonlyPaths (#587)
* config-linux: Only require /dev/console when process.terminal is
true. Also require /dev/console to be provided by a bind mount
(#518)
* runtime: Require runtimes to generate errors when the container
specified in config.json cannot be created (#559, although there's
an in-flight typo-fix in #643).

and lots of minor fixes and documentation. Sometimes the boundary
between “breaking change”-ness is fuzzy when the previous behavior was
underspecified, but I've done my best to categorize them appropriately
(with potentially consumer-breaking stuff under “Removals and
increased restrictions”).

I can usually turn one of these ChangeLog sections around within a few
hours, so if you want the voted commit to include a ChangeLog update
and don't have anyone else around to work one up, just ping me the day
before you launch the vote.

Cheers,
Trevor

[1]: https://github.com/wking/opencontainer-runtime-spec/tree/rc3-changelog

--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[Tianon Gravi]

LGTM

♥,
- Tianon
4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4

[Brandon Philips]

LGTM

[Huangqiang (H)]

LGTM

[Michael Crosby]

LGTM

--

Michael Crosby

@crosbymichael

[Mrunal Patel]

LGTM

[Dao Quang Minh]

Can we pull Trevor's Changelog in just like how we did in rc2 ? https://github.com/opencontainers/runtime-spec/pull/557

[Vincent Batts]

On Mon, Dec 12, 2016 at 1:01 PM Dao Quang Minh <dqmi...@gmail.com> wrote:

Can we pull Trevor's Changelog in just like how we did in rc2 ? https://github.com/opencontainers/runtime-spec/pull/557

done

 

On Mon, Dec 12, 2016 at 5:51 PM, Mrunal Patel <mpa...@redhat.com> wrote:

LGTM

On Mon, Dec 12, 2016 at 9:39 AM, Michael Crosby <michael...@docker.com> wrote:

LGTM

On Thu, Dec 8, 2016 at 10:17 PM, Huangqiang (H) <h.huan...@huawei.com> wrote:

LGTM

On Friday, December 09, 2016 at 3:01 AM UTC+8, Brandon Philips wrote:
> LGTM
>
> On Wednesday, December 7, 2016 at 8:41:20 AM UTC-8, Vincent Batts wrote:
> > Hey y'all,
> >
> > It's been since 2016-09-08 that v1.0.0-rc2 was commited, and since then there has been 49 pull requests merged.
> >
> > https://github.com/opencontainers/runtime-spec/pull/642 is the PR that includes the commit to be tagged
> >
> >
> > If you agree reply with LGTM.
> > If you disagree reply with REJECT and your reasoning.
> >
> > vb

--

Michael Crosby

@crosbymichael

--
You received this message because you are subscribed to the Google Groups "dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.

[Dao Quang Minh]

LGTM

To unsubscribe from this group and stop receiving emails from it, send an email to dev+unsubscribe@opencontainers.org.

[Vincent Batts]

[explicit] LGTM

We're only lacking Alexander for it to be unanimous.

LGTM

To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.

[Vincent Batts]

On Tue, Dec 13, 2016 at 8:09 AM Vincent Batts <vba...@gmail.com> wrote:

[explicit] LGTM

We're only lacking Alexander for it to be unanimous.

Ah, also missing Vishnu's voice. :-)

[michael...@docker.com]

I think Vishh is on vacation and so is Alex.

Michael Crosby

[Vincent Batts]

good to know.

Without their votes we're still at 77% which is a passing vote. We'll wait the 21 hours for this vote to close and I'll tag the release.

If a couple maintainers will LGTM the PR on github please: https://github.com/opencontainers/runtime-spec/pull/642

vb

[Vincent Batts]

Congrats all. This vote passed (a couple hours ago). 

The release, tag and docs are here: https://github.com/opencontainers/runtime-spec/releases/tag/v1.0.0-rc3

​

vb

LGTM

To unsubscribe from this group and stop receiving emails from it, send an email to dev+unsubscribe@opencontainers.org.