LGTM
--
You received this message because you are subscribed to the Google Groups "dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.
I have a few concerns, but only one I think might possibly be blocking. They are:
1. (Not a blocker) There are a few places where the wording is a little troublesome. Specifically:
a) It discusses a cadence "greater" than 4 weeks. What does this mean? I assume greater means "less frequent" given the context but it's not clear. I suggest changing it to clarify.
b) What's a "breaking change"? Such a change would restart the rc cycle, but it isn't defined.
c) (While I'm here, might as well point this out) In Specifications->Planning a release, there's a grammar error:
Every OCI specification project SHOULD hold meetings that involves -> Every OCI specification project SHOULD hold meetings that involve
2. (Possibly a blocker) What's the procedure for changing the release requirements document? It doesn't outline the procedure for updating itself. Is that elaborated elsewhere? Should we define a procedure for changing it before we release it so that we know how to change it later?
As long as we're confident we have an agreed upon way to update the procedure later, I'm fine with approving as it is and fixing other problems later.
Largely LGTM. One nit added to the PR.I'd like to see Jason's #2 clarified also.
LGTM
[2]: Message-ID: <CAD2oYtMsOEB=DWRCihnTrNJ1m6RuJR-C3XjUOorz4DNOKdfMcA@mail.gmail.com>
[3]: Message-ID: <CACVcpfphxxtSHMPoeQskFE1FA7X1u3RO5aBd0RUZ7orMXuZReg@mail.gmail.com>
[4]: Message-ID: <CAHnKnK23AjMO__QDMrbK9ePK-y-HUcYtPCUXjK38hVV6HioQYQ@mail.gmail.com>
[5]: Message-ID: <CAOviyajcxbbqZOoPQWTwv25iFT=NqR36xz+AtqgQv5xJXpCQ-w@mail.gmail.com>
[6]: Message-ID: <CAFoGUixNA49nKmrdMA-Pqqf5aA=BOftUZJ0+0WxqfccQZXmFeQ@mail.gmail.com>
[7]: Message-ID: <CAFi6z1HAkKbnMoAXubyGusQJ_MromgpQ4qHCQ3R9_NwZNYBX5w@mail.gmail.com>
[8]: https://github.com/philips/tob/commit/37088fbfa66b5bbda4f0b1805b35e4eb37589e45
[9]: Message-ID: <CAD2oYtP7c-xSyXv9Jdz8X=6WOZRwxB8dno4_DADw8Q4hgHK=m...@mail.gmail.com>
[10]: Message-ID: <CAN6Zp5y2=+U6niSDGGQC1ag0o8PCbpDLm4Y0k4BVNyEJxh-0mA@mail.gmail.com>
[11]: https://github.com/philips/project-template/commit/c9a01f5fb1c59c91d7ebba624f0dc6970f863d6c
[12]: Message-ID: <CAD2oYtPazRCBNHRHGyUt=wAA+=fber0AErqz5rnf4irc=QX...@mail.gmail.com>
[13]: Message-ID: <CAFi6z1Hq5t53LwPEe47gNHbWbM7=spWmha8Z99eLFd9fo2otOw@mail.gmail.com>
[14]: Message-ID: <SN1PR0301MB207885AF856FF28A83DC22B7E0230@SN1PR0301MB2078.namprd03.prod.outlook.com>
[15]: Message-ID: <CANEZBD5UnZbUSseb4xA5OLMFKzwDBw1tEo=m=uC8L3i...@mail.gmail.com>
[16]: Message-ID: <CAMrcrYOVRKQk91U34x3oWjg16rbgyF1gWziz3gBTXPMJoyoG2w@mail.gmail.com>
[17]: Message-ID: <CAN6Zp5wkKX+GvB7wW04QcukYUVq-i1sJETvmCRtubSJk+ER1tQ@mail.gmail.com>