[runtime-spec VOTE] tag e45c2e6 as v1.0.0 (closes Wed Jul 19 18:46:01 UTC 2017)

[Vincent Batts]

Hey everyone,

This is it, the vote for v1.0.0 of the runtime specification.

This tag is effectively the same as the rc6 tag, but with the version bump (also a ChangeLog update and removal of pre-v1 roadmap).

The PR of this commit: https://github.com/opencontainers/runtime-spec/pull/893

If you agree reply with LGTM.

If you disagree reply with REJECT and your reasoning.

vb

[Tianon Gravi]

LGTM

Full diff: https://github.com/opencontainers/runtime-spec/compare/v1.0.0-rc6...e45c2e6

♥,
- Tianon
4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4

> --
> You received this message because you are subscribed to the Google Groups
> "dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to dev+uns...@opencontainers.org.

[Vincent Batts]

oh there were other merges, but they are needed. Thanks for that clarification.

[Vincent Batts]

Heads up from the weekly discussion. As this vote was just kicked off a few hours ago, we decided to get https://github.com/opencontainers/runtime-spec/pull/895 and "relocation of the oom adjust score to memory" merged, and rebase this v1.0.0 vote with the two PRs.

vb

[Vincent Batts]

Okay all,

All-clear to review https://github.com/opencontainers/runtime-spec/pull/893 as the v1.0.0 vote. The PRs https://github.com/opencontainers/runtime-spec/pull/896 and https://github.com/opencontainers/runtime-spec/pull/897 were pulled in, as decided in the weekly call today.

Tianon, please recast your LGTM/REJECT once you've reviewed.

All others, 

If you agree reply with LGTM.

If you disagree reply with REJECT and your reasoning.

vb

[W. Trevor King]

On Wed, Jul 12, 2017 at 11:39:54PM +0000, Vincent Batts wrote:
> All-clear to review
> https://github.com/opencontainers/runtime-spec/pull/893 as the
> v1.0.0 vote.

The commit to be tagged is actually 02137cd4, where the version is set
to 1.0.0 [1]. e45c2e6 (which you give in your title) is a post-1.0.0
commit which you've included in the PR to ease development into
whatever the next version is going to be (although I'm not sure we
know what version that will be [2]). Maybe we should drop e45c2e6
from the PR and figure out the post-1.0 branching strategy first?

Does an opinionated maintainer want to open a thread on branching
strategies? I'm happy to launch one if there are no opinionated
maintainers ;).

Cheers,
Trevor

[1]: https://github.com/opencontainers/runtime-spec/pull/893/commits/02137cd4e50b37a01665e1731fcd4ac2d2178230
[2]: https://github.com/opencontainers/runtime-spec/pull/893#discussion_r127100321

--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[Tianon Gravi]

LGTM (commit 02137cd)

Full compare link:
https://github.com/opencontainers/runtime-spec/compare/v1.0.0-rc6...02137cd
(for future reviewers, if you so choose to re-review full diff from
previous release to proposed-v1.0.0)

♥,
- Tianon
4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4

[Qiang Huang]

LGTM

[Mrunal Patel]

LGTM

To unsubscribe from this group and stop receiving emails from it, send an email to dev+unsubscribe@opencontainers.org.

[Michael Crosby]

LGTM

--

Michael Crosby

@crosbymichael

[Vishnu Kannan]

LGTM

LGTM

LGTM

To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.

--

Michael Crosby

@crosbymichael

[bra...@ifup.org]

LGTM

[Dao Quang Minh]

There are a few open minors changes to the schema.json, do we want to pull those in as well ?

- https://github.com/opencontainers/runtime-spec/pull/899

- https://github.com/opencontainers/runtime-spec/pull/898

- https://github.com/opencontainers/runtime-spec/pull/891

- https://github.com/opencontainers/runtime-spec/pull/889

On Mon, Jul 17, 2017 at 3:26 PM, <bra...@ifup.org> wrote:

LGTM

--
You received this message because you are subscribed to the Google Groups "dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dev+unsubscribe@opencontainers.org.

[Vincent Batts]

On Mon, Jul 17, 2017 at 10:50 AM Dao Quang Minh <dqmi...@gmail.com> wrote:

There are a few open minors changes to the schema.json, do we want to pull those in as well ?

- https://github.com/opencontainers/runtime-spec/pull/899

- https://github.com/opencontainers/runtime-spec/pull/898

- https://github.com/opencontainers/runtime-spec/pull/891

- https://github.com/opencontainers/runtime-spec/pull/889

these seem ok for a 1.0.Z 

 

On Mon, Jul 17, 2017 at 3:26 PM, <bra...@ifup.org> wrote:

LGTM

--
You received this message because you are subscribed to the Google Groups "dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.

--
You received this message because you are subscribed to the Google Groups "dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencontainers.org.

[W. Trevor King]

On Mon, Jul 17, 2017 at 02:54:58PM +0000, Vincent Batts wrote:

> On Mon, Jul 17, 2017 at 10:50 AM Dao Quang Minh wrote:
> > There are a few open minors changes to the schema.json, do we want
> > to pull those in as well ?
> >
> > - https://github.com/opencontainers/runtime-spec/pull/899
> > - https://github.com/opencontainers/runtime-spec/pull/898
> > - https://github.com/opencontainers/runtime-spec/pull/891
> > - https://github.com/opencontainers/runtime-spec/pull/889
>
> these seem ok for a 1.0.Z

#889 would be a patch level bump if our SemVer covered JSON Schema
consumers (who, with #889, gain the ability to validate
linux.intelRdt). There seems to be some disagreement, or at least
confusion, about what our SemVer covers [1]. Vincent suggesting those
PRs are all patch-level changes implies that he agrees with me that
JSON Schema consumers are not covered by our SemVer, but it would be
nice to spell that out somewhere (after we cut 1.0?). Otherwise JSON
Schema consumers unaware of these previous decisions might consider
themselves protected.

Cheers,
Trevor

[1]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-07-12-21.02.log.html#l-42

[Vincent Batts]

Reminder, this vote closes on Wednesday July 19th (2 days away). 

vb

[Dao Quang Minh]

LGTM

i'm ok with those 4 patches in 1.0.x