[runtime-spec VOTE] tag 4e3b926 as v1.0.1 (closes Mon Nov 6 13:00:27 UTC 2017)

112 views
Skip to first unread message

Vincent Batts

unread,
Oct 30, 2017, 9:01:18 AM10/30/17
to Michael Crosby, Kannan, Patel, Batts, Dao Quang Minh, Philips, Gravi, Huang, dev
rats, i hit send to quick!

updated the subject line. This vote is on a rebased master, including
the updated changelog.

On Mon, Oct 30, 2017 at 8:57 AM, Vincent Batts <vba...@redhat.com> wrote:
> Hey y'all,
>
> There have been 19 PRs merged since 1.0.0
>
> https://github.com/opencontainers/runtime-spec/pull/919
>
> Please respond LGTM or REJECT (with reasoning).
>
> vb

Dao Quang Minh

unread,
Oct 30, 2017, 9:50:10 AM10/30/17
to Vincent Batts, Michael Crosby, Kannan, Patel, Philips, Gravi, Huang, dev
LGTM.

Mrunal Patel

unread,
Oct 30, 2017, 10:28:23 AM10/30/17
to Dao Quang Minh, Vincent Batts, Michael Crosby, Kannan, Philips, Gravi, Huang, dev
LGTM

Tianon Gravi

unread,
Oct 30, 2017, 12:10:36 PM10/30/17
to Vincent Batts, Michael Crosby, Kannan, Patel, Dao Quang Minh, Philips, Huang, dev
LGTM

Full diff: https://github.com/opencontainers/runtime-spec/compare/v1.0.0...4e3b926

♥,
- Tianon
4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4

Qiang Huang

unread,
Oct 30, 2017, 9:07:13 PM10/30/17
to dev, dqmi...@gmail.com, vba...@redhat.com, mic...@docker.com, vis...@google.com, brandon...@coreos.com, admw...@gmail.com, h.huan...@huawei.com
LGTM

Michael Crosby

unread,
Oct 31, 2017, 1:27:20 PM10/31/17
to Qiang Huang, dev, Dao Quang Minh, Vincent Batts, Michael Crosby, Vishnu Kannan, Brandon Philips, Tianon Gravi
LGTM
--
Michael Crosby
@crosbymichael

Brandon Philips

unread,
Oct 31, 2017, 1:28:35 PM10/31/17
to Michael Crosby, Qiang Huang, dev, Dao Quang Minh, Vincent Batts, Michael Crosby, Vishnu Kannan, Tianon Gravi
LGTM

On Tue, Oct 31, 2017 at 10:27 AM Michael Crosby <michael...@docker.com> wrote:
LGTM

On Mon, Oct 30, 2017 at 9:07 PM, Qiang Huang <h.huan...@huawei.com> wrote:
LGTM

On Monday, October 30, 2017 at 10:28:23 PM UTC+8, Mrunal Patel wrote:
LGTM

On Mon, Oct 30, 2017 at 6:50 AM, Dao Quang Minh <dqmi...@gmail.com> wrote:
LGTM.

On Mon, Oct 30, 2017 at 1:01 PM, Vincent Batts <vba...@redhat.com> wrote:
> rats, i hit send to quick!
>
> updated the subject line. This vote is on a rebased master, including
> the updated changelog.
>
 > On Mon, Oct 30, 2017 at 8:57 AM, Vincent Batts <vba...@redhat.com> wrote:
>> Hey y'all,
>>
>> There have been 19 PRs merged since 1.0.0
>>
>> https://github.com/opencontainers/runtime-spec/pull/919
>>
>> Please respond LGTM or REJECT (with reasoning).
>>
>> vb




--
Michael Crosby
@crosbymichael
--
CTO, CoreOS, Inc
Tectonic is enterprise Kubernetes

Vishnu Kannan

unread,
Oct 31, 2017, 4:31:27 PM10/31/17
to Brandon Philips, Michael Crosby, Qiang Huang, dev, Dao Quang Minh, Vincent Batts, Michael Crosby, Tianon Gravi
LGTM
Reply all
Reply to author
Forward
0 new messages