[proposal] Exception for admin interface reviews for BugBash

20 views
Skip to first unread message

Lars Kiesow

unread,
May 31, 2024, 6:03:10 AM5/31/24
to d...@opencast.org
Hi everyone,
usually, we expect all pull requests to be discussed in the technical
meeting before merging. That doesn't really make sense for the BugBash
were we want to act fast. That's why I propose to temporarily drop that
rule from now until the end of the BugBash EOD next Wednesday.

This proposal passes if no one objects until Sun Jun 2 12:02:22 PM
CEST 2024.

Best regards,
Lars

Katrin Ihler

unread,
May 31, 2024, 8:17:08 AM5/31/24
to d...@opencast.org
+1
> To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@opencast.org.
>
>
--
elan e.V.
Karlstr. 23
D-26123 Oldeburg

elan-ev.de

Greg Logan

unread,
May 31, 2024, 9:42:21 AM5/31/24
to d...@opencast.org
This would apply to the admin interface repo alone, correct? If so, sounds good to me. If we do somehow need to rapidly merge in something in the backend repo we can be pragmatic at that point.

G

Daniel Ziegenberg

unread,
May 31, 2024, 10:43:38 AM5/31/24
to d...@opencast.org

Do we plan to have any replacement for "discussed in the technical meeting" like we require two approvals on a PR? We should keep a chance to discuss or object.


greetings, Daniel

Carlos Turro Ribalta

unread,
May 31, 2024, 1:27:28 PM5/31/24
to d...@opencast.org
+1

-----Mensaje original-----
De: d...@opencast.org <d...@opencast.org> En nombre de Katrin Ihler
Enviado el: viernes, 31 de mayo de 2024 14:15
Para: d...@opencast.org
Asunto: Re: [OC Dev] [proposal] Exception for admin interface reviews for BugBash

Lars Kiesow

unread,
Jun 2, 2024, 6:17:33 PM6/2/24
to d...@opencast.org
Hi

> This would apply to the admin interface repo alone, correct?

Yes. That was my intention. Sorry if that wasn't clear.

> Do we plan to have any replacement for "discussed in the technical
> meeting" like we require two approvals on a PR? We should keep a
> chance to discuss or object.

There are three additional meetings we can use to discuss pull
requests. But more than that I hope that the committers who participate
in the event will communicate with us all about potentially
controversial patches. We all know each other and since this event will
force us to work in parallel, it should be easy to reach out at any
time.

–Lars


On Fri, 31 May 2024 16:43:35 +0200
Daniel Ziegenberg <dan...@ziegenberg.at> wrote:

> Do we plan to have any replacement for "discussed in the technical
> meeting" like we require two approvals on a PR? We should keep a
> chance to discuss or object.
>
>
> greetings, Daniel
>
>
> On 31.05.24 15:42, Greg Logan wrote:
> > This would apply to the admin interface repo alone, correct? If so,
> > sounds good to me. If we do somehow need to rapidly merge in
> > something in the backend repo we can be pragmatic at that point.
> >
> > G
> >
> > On Fri, May 31, 2024, 04:03 Lars Kiesow <lki...@uos.de> wrote:
> >
> > Hi everyone,
> > usually, we expect all pull requests to be discussed in the
> > technical meeting before merging. That doesn't really make sense
> > for the BugBash were we want to act fast. That's why I propose to
> > temporarily drop that
> > rule from now until the end of the BugBash EOD next Wednesday.
> >
> > This proposal passes if no one objects until Sun Jun  2
> > 12:02:22 PM CEST 2024.
> >
> > Best regards,
> > Lars
> >
> > To unsubscribe from this group and stop receiving emails from
> > it, send an email to dev+uns...@opencast.org
> > <mailto:dev%2Bunsu...@opencast.org>.
Reply all
Reply to author
Forward
0 new messages