Name collision with Java builtin method

[Yuta Higuchi]

Hi Gaurav, 

I've encountered another type of collision.

This time, .yang contained something like:

       container periodic-traceroute {

         ...

         leaf wait {

           ...

         }

       }

compiler generated wait() method on the .java file,

but it collides with Object#wait() which is declared final, and compilation of that file fails.

I'm not completely sure how to resolve this issue.

May be, maintain a blacklist of built-in methods names,

and if the method compiler attempt to create matches it,

add prefix or suffix. 

I'm hoping this approach will work assuming, 

no one will try to invoke method via reflection based on 

yang schema, which probably is unlikely.

What do you think?

Thanks,

Yuta

[Yuta Higuchi]

It turned out that actually, there already was a black listing mechanism to avoid stepping on Java defined keywords, etc.

I've added the wait and other methods defined on Object class to that black list.

 https://gerrit.onosproject.org/15026