Support for MultiPointToSinglePoint and SinglePointToMultiPoint intents support in ONOS 1.6 version

[anil kumar gajji]

Hi,

Is there any plan to support for "MultiPointToSinglePoint" and "SinglePointToMultiPoint" intent creation in ONOS 1.6 GA release?

Thank you

[Jonathan Hart]

Hi,

Yes, these intents are supported in ONOS 1.6.

Thanks

--
You received this message because you are subscribed to the Google Groups "ONOS Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to onos-discuss...@onosproject.org.
To post to this group, send email to onos-d...@onosproject.org.
Visit this group at https://groups.google.com/a/onosproject.org/group/onos-discuss/.
To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/111617a5-2afd-4176-b791-f93b87bb1107%40onosproject.org.

[anil kumar gajji]

Jonathan,

But when i tried to create intent through REST call I could see not supported error message.

For reference here is request response:

Req:

POST: /onos/v1/intents

payload:

{
  "type": "MultiPointToSinglePointIntent",
  "appId": "org.onosproject.fwd",
  "selector": {
    "criteria": [
      {
        "type": "ETH_SRC",
        "mac": "1E:0E:FB:B4:2A:94"
      }, 
      {
        "type": "ETH_DST",
        "mac": "32:F1:FD:8A:45:4B"
      },
      {
          "type": "VLAN_VID",
          "vlanId": "10"
      }
    ]
  },
  "treatment": {
    "instructions": [
      {
        "type": "NOACTION"
      }
    ],
    "deferred": []
  },
  "priority": 66,
  "constraints": [
    {
      "inclusive": false,
      "types": ["OPTICAL"],
      "type": "LinkTypeConstraint"
    }
  ],
  "ingressPoint": [{
    "port": "1",
    "device": "of:0000000000000001"
  },{
    "port": "2",
    "device": "of:0000000000000002"
  }],
  "egressPoint": {
    "port": "2",
    "device": "of:0000000000000001"
  }
}

Response for above request is:

{
  "code": 400,
  "message": "Intent type MultiPointToSinglePointIntent is not supported"
}

And I have observed that codec classes for "MultiPointToSinglePointIntent" and "SinglePointToMultiPointIntent" are not available in 1.6 branch.

[Jonathan Hart]

Hi,

It looks like the codecs were never implemented to be able to decode these kinds of intents from calls to the REST API, but the intents are still supported in the Java API. I don't see codecs for those intents in 1.5 either.

Would you be interested in implementing these codecs to support these intents over REST? It should be fairly straightforward if you follow the example of the PointToPointIntentCodec.

Thanks,

Jono

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/719e74b1-54eb-4b65-bb43-9a9520971791%40onosproject.org.

[Chiara]

Hi guys,

I've recently implemented the SinglePointToMultiPointIntentCodec because I needed it for an application that I'm implementing. Now I'm able to successfully POST /intents and GET /intents/{appId}/{key} seeing all intents' details. 

If no one has already given his/her contribute about this codec, I would be interested in sharing my implementation.

Thanks.

Chiara

[anil kumar gajji]

Hello Chiara,

Good to know that you are done with implementation part for SinglePointToMultiPointIntentCodec. I think you can go for contribution.

Do you even have implementation for MultiPointToSinglePointIntentCodec?

Thanks,

Anil Kumar Gajji

--

Thanks & Regards,
Anil kumar Gajji

[Chiara Contoli]

At the moment I do not have the MultiPointToSinglePointIntentCodec implementation, just the the SinglePointToMultiPointIntentCodec, but I will try to find some bandwidth to implement also that MP2SP codec.

I’m actually new to the process of submitting a contribution to the codebase; can anyone please point me out any guide that I should follow to start the process? I had a quick look on the wiki and I found the following: 

https://wiki.onosproject.org/display/ONOS/Contributing+to+the+ONOS+Codebase

Can I start form here? any further suggestion is more than welcome.

Thanks.

Chiara

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/CAMoNe0dNQTaUHAnc0Y8pMR3ShA3fkocH2yO_h2TLeSXKtThObQ%40mail.gmail.com.

[Luca Prete]

Chiara,

Could you please send your code on Gerrit, so we can review it and merge it?

We might do it through two reviews: one for sp2mp and another one for mp2sp.

Thanks!

-Luca

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/8958BEAF-9585-4581-9171-7E82526B396F%40gmail.com.

[Aris]

Hello,

Any update for MP2SP codec implementation?

I check with the latest ONOS code, but it still missing.

Thanks,

Aris.

[Luca Prete]

Aris,

This has not been tackled yet. This is not a trivial refactor and was recently de-prioritized, in comparison to other tasks.

We'll let you know as soon as something moves on.

Cheers,

-Luca

To unsubscribe from this group and stop receiving emails from it, send an email to onos-discuss+unsubscribe@onosproject.org.

To post to this group, send email to onos-d...@onosproject.org.
Visit this group at https://groups.google.com/a/onosproject.org/group/onos-discuss/.

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/6a0c545f-fac0-45c0-948e-9ec89bf69830%40onosproject.org.

[Aris Risdianto]

Thanks Luca for your reply.

How much is the complexity?

Is it written somewhere in the ONOS Jira? which I can check it out?

Because, I really need MP2SP for my implementation.

I may consider to contribute for it.

Best Regards,

Aris.

[Luca Prete]

It might be quite complex, but it's nothing impossible to achieve. Your contribution would be very welcome!
We don't have (yet) timelines for that on our side...and I don't have many details. Actually Pier Luigi Ventre has been the last one taking care of that. Hopefully he'll be able to provide some more details.

For my curiosity, why SP2MP and MP2SP, or simply multiple SP intents are not enough for your project?

Thanks!

-Luca

[Aris Risdianto]

Hi Luca,

I will try to check the detail code. 

SP2MP is good place to check, isn't ?

My project need to get the SDN-IP's MP2SP intent in detail.

Because, I want to make some limited coordination between two independent ONOS Controllers. So, I want to override SDN-IP's intent by adding MP2SP lower priority value for specific-defined condition.

Best Regards,

Aris.

[Pier Luigi Ventre]

Hi Aris,

a good starting point could be IntentsWebResource.creatIntent(). From there you can follow the flow execution that goes through IntentCodec. 

Let me know if you need more guidance.

Thanks

Pier

To unsubscribe from this group and stop receiving emails from it, send an email to onos-discuss...@onosproject.org.

To post to this group, send email to onos-d...@onosproject.org.
Visit this group at https://groups.google.com/a/onosproject.org/group/onos-discuss/.

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/6a0c545f-fac0-45c0-948e-9ec89bf69830%40onosproject.org.

[Aris Risdianto]

Thanks Pier,

Actually I start with IntentsWebResource.getIntentById().
I have modified to add MP2SP intent and create MP2SP codec
implementation, but I still this error.

{"code":500,"message":"org.onosproject.rest.resources.IntentsWebResource.getIntentById(IntentsWebResource.java:136)"}

I did some testing and I found :

with this " encode((SinglePointToMultiPointIntent) intent, this) " I get this :

{"type":"MultiPointToSinglePointIntent","id":"0x100024","appId":"org.onosproject.sdnip","resources":[],"state":"INSTALLED","selector":{"criteria":[]},"treatment":{"instructions":[{"type":"L2MODIFICATION","subtype":"ETH_DST","mac":"90:E2:BA:1E:34:30"}],"deferred":[]},"priority":225,"constraints":[{"type":"PartialFailureConstraint"}],"ingressPoint":[{"port":"14","device":"of:0065a0b3ccf32380"}],"egressPoint":{"port":"15","device":"of:0065a0b3ccf32380"}}

But when I called through Codec
"codec(SinglePointToMultiPointIntent.class).encode((SinglePointToMultiPointIntent)
intent, this)" It is failed due to "java.lang.NullPointerException"

Do I need to register my new codec implementation or is it already
known problem?


Regards,
Aris.

> You received this message because you are subscribed to a topic in the

> Google Groups "ONOS Discuss" group.

> To unsubscribe from this topic, visit
> https://groups.google.com/a/onosproject.org/d/topic/onos-discuss/KeroMm2F9Pw/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to

> onos-discuss...@onosproject.org.
> To post to this group, send email to onos-d...@onosproject.org.
> Visit this group at
> https://groups.google.com/a/onosproject.org/group/onos-discuss/.
> To view this discussion on the web visit

> https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/ad7f8f05-f3fb-479b-9b80-24d498b5d6ed%40onosproject.org.

[Pier Luigi Ventre]

Hi Aris,

can you push your review on gerrit and add me as reviewer ?

Thanks

Pier

[Aris Risdianto]

Ok Pier.

I will try to upload and inform you when I am done.

Thanks,

Aris.

To unsubscribe from this group and all its topics, send an email to onos-discuss+unsubscribe@onosproject.org.

To post to this group, send email to onos-d...@onosproject.org.
Visit this group at https://groups.google.com/a/onosproject.org/group/onos-discuss/.

To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/onos-discuss/bdf8b1ab-cb31-4ba4-ba0a-5f2171fa6285%40onosproject.org.