Re: Metering/ Rate limiting in ONOS

37 views
Skip to first unread message

Luca Prete

unread,
Aug 9, 2017, 10:54:27 AM8/9/17
to Pier Luigi Ventre, Yuta Higuchi, Yi Tseng, Sho Shimizu, Andrea Campanella, Thomas Vachuska, Brian O'Connor, brigade-n...@onosproject.org, brigade-d...@onosproject.org
[Including Thomas Vachuska, Brian, NB brigade and deployment brigade]

Pier,

Thanks a lot! This will be for sure the beginning of a very useful work!

We'll look into it asap.

Ciao

-Luca

On Wed, Aug 9, 2017 at 4:40 PM, Pier Luigi Ventre <pl.v...@gmail.com> wrote:
Hi guys,
How are you doing ? I hope you are fine :).

I am reaching you because I found some time to work on the tasks related to the metering/rate limiting support in ONOS (activities in the context of the NB brigade), described roughly in the following issues:
- https://jira.onosproject.org/browse/ONOS-5868 -> Flow objectives subsystem
- https://jira.onosproject.org/browse/ONOS-5869 -> Driver
- https://jira.onosproject.org/browse/ONOS-5867 -> Intent FW

The high level design has been described in this document:
https://docs.google.com/document/d/11raBMJGrn9RSDtZ5wYxD4t0Hgeo1qL2jGYKvp6URvIU/edit

Any further comment will be helpful (Yuta and Sho).

The idea is to start with the first two tasks and then move to the IntentFW when the first two have been consolidated. Then for the last part, I think we need to have a chat to understand if the resource service is a suitable solution.

The first patch will extend the Flow objective API, if you have any comment or advice before I start it will be great.

Thanks
Pier



--
Luca Prete
Open Networking Foundation

Yuta Higuchi

unread,
Aug 9, 2017, 5:47:47 PM8/9/17
to Luca Prete, Pier Luigi Ventre, Yi Tseng, Sho Shimizu, Andrea Campanella, Thomas Vachuska, Brian O'Connor, brigade-n...@onosproject.org, brigade-d...@onosproject.org
I would suggest something along the line of 2),
Intent request SB side to enforce certain policy/BW profile and SB driver chose how to realize them, in the case of OF, it'll use Meter.
I think meter is too fine grained construct to be handled directly by Intent F/W itself.


If we have infinite time, I would try to model it in a way slightly similar to FilteringConnectPoint.
That is, define an entity sort of like virtual port, which has information about rate limiting characteristics.

Unlike existing FilteringConnectPoint case, it would probably be better to define a new kind of Intent to define 
this entity first then define connectivity intent .

So setup procedure will be something like:
- Creates Intents to define service endpoints, which may contain filtering condition, BW policy.
- Then create Connectivity Intent specifying those endpoints.

But, it'll open up can of worms,
- Intent depending on other Intent, 
- composing FlowRule/Objective from multiple Intents, 
- virtual port for endpoints?
 ...
so may be just forget about it for now.



Yi Tseng

unread,
Aug 9, 2017, 6:03:15 PM8/9/17
to Pier Luigi Ventre, Luca Prete, Yuta Higuchi, Sho Shimizu, Andrea Campanella, Thomas Vachuska, Brian O'Connor, brigade-n...@onosproject.org, brigade-d...@onosproject.org
Hi Pier,
Long time no see!

I was thinking about another installable Intent for bandwidth allocation (e.g. BandwidthIntent).

I think it is much easier to add new installable Intent (also the installer) then new Objective

We just need to generate some BandwidthIntent by the compiler, and the installer handles bandwidth allocating task.

What do you think?

Yi

Pier Luigi Ventre

unread,
Aug 11, 2017, 4:34:59 AM8/11/17
to Yi Tseng, Yuta Higuchi, Luca Prete, Sho Shimizu, Andrea Campanella, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade
Hi Yuta, Yi,
thanks for the reply.

Yuta, to be clear I don’t want to use Meter in the IntentFW, in the ticket I used metering but I meant something of generic and I think your suggestion of creating another extension of the connect point can be interesting.

Yi, yes this could be another part but in my mind I would create another installer if change technological domain (for example from OpenFlow to...), can you elaborate a little bit more ? To be clear here I want to tackle metering and rate limiting even if bandwidth allocation is related but it is a different task. The necessity of a new objective is given from the fact I want to offload to the Pipeliners (at least for OpenFlow) the translation from this new Objective to Meter and make sure that race conditions between Meter and flows pointing to it are not a problem (like we do today with Flows and Groups).

I will try to think more about these suggestions and I will do a revisitation of the above document with my new thoughts.

Thanks
Pier

Pier Luigi Ventre

unread,
Aug 14, 2017, 9:55:54 AM8/14/17
to Yi Tseng, Yuta Higuchi, Luca Prete, Sho Shimizu, Andrea Campanella, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade
Hi guys,
I did a revisitation of the previous design taking into account your suggestions and mixing old and new ideas.

The design is in this new doc: 

Unfortunately, I was not able to reuse the previous one, I think I created with my old ON.LAB account :(.

The design is quite complex and for sure I am missing something from the big picture :). Let me know what do you think about it.

Thanks
Pier

Andrea Campanella

unread,
Aug 22, 2017, 10:43:38 AM8/22/17
to Pier Luigi Ventre, Yi Tseng, Yuta Higuchi, Luca Prete, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade
Hi Pier,

the design looks good to me. I'm sure some implementation details and complication will arise once the code start getting created. I think starting on it with this foundation and the adapting once moving is the right approach.
I'll let also other chime in.

Cheers,
Andrea Campanella

Member of Technical Staff at ONF
Member of Ambassador Steering Team, ONOS and CORD Community



Yuta Higuchi

unread,
Aug 22, 2017, 3:56:36 PM8/22/17
to Pier Luigi Ventre, Yi Tseng, Luca Prete, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Andrea Campanella
Hi Pier,

Sorry I've missed the e-mail with the update.

I've added comment on the document, mainly around TCCP.
I'm just thinking out loud on those comments, 
so don't take as strong suggestion that it should be that way or anything.


Luca Prete

unread,
Aug 24, 2017, 5:33:59 PM8/24/17
to Yuta Higuchi, Pier Luigi Ventre, Yi Tseng, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Andrea Campanella
Pier,

I think we've somehow a (small) consensus. I guess you're the expert here and our feedback is just an opinion. Maybe we should wait for a second opinion from Thomas as well? ..not sure..
Do you think you'll be able to contribute also in the development phase? Any help needed? Should we involve more the community and ask for help?

-Luca

Pier Luigi Ventre

unread,
Aug 28, 2017, 3:27:55 AM8/28/17
to Luca Prete, Yuta Higuchi, Yi Tseng, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Andrea Campanella
Luca, guys

sorry I was in vacation :). I will reply to the technical questions asap.

Luca, I don’t think we need other opinions for now, unless people see critical parts in the proposed design. At the end, it “is" still in the Intent FW.

I will take care also of the development effort. Then if someone of the community is willing to help they are welcome.

Thanks
Pier

Pier Luigi Ventre

unread,
Aug 31, 2017, 11:41:59 AM8/31/17
to Yuta Higuchi, Andrea Campanella, Yi Tseng, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Stefano Salsano, Luca Prete
Yuta, Andrea.
Thanks for the suggestions and your comments.

I have updated the document, I hope I have clarified what I have in mind. 
Agree with Yuta on developing the BW enforcement in two phases.

Yuta, I am not sure about your concerns and I don’t know if I understood well the example you provided with two policers. 
If you can provide more details I would really appreciate.

Thanks
Pier

Luca Prete

unread,
Aug 31, 2017, 4:54:55 PM8/31/17
to Pier Luigi Ventre, Yuta Higuchi, Andrea Campanella, Yi Tseng, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Stefano Salsano
Pier, this is great. Thanks a lot!

Please, let me know how can I help or facilitate your work in any way.

Ciao

-Luca

--
You received this message because you are subscribed to the Google Groups "ONOS Deployments Brigade" group.
To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deployments+unsub...@onosproject.org.
To post to this group, send email to brigade-deployments@onosproject.org.
Visit this group at https://groups.google.com/a/onosproject.org/group/brigade-deployments/.
To view this discussion on the web visit https://groups.google.com/a/onosproject.org/d/msgid/brigade-deployments/0A002667-3CE0-480F-A9BE-0F8C7358CAA3%40gmail.com.

Pier Luigi Ventre

unread,
Sep 4, 2017, 8:03:16 AM9/4/17
to Luca Prete, Yuta Higuchi, Andrea Campanella, Yi Tseng, Sho Shimizu, Thomas Vachuska, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Stefano Salsano
Luca,
had a chat with Yuta (offline), I think more or less we found an agreement and we defined some items to be discussed for the future (points related to Phase 2). If there are no objections I will close ONOS-5891, I will start to put items in Jira for Phase 1 and I will prioritize them.

Thanks
Pier

Luca Prete

unread,
Sep 5, 2017, 10:47:35 AM9/5/17
to Pier Luigi Ventre, Andrea Campanella, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Sho Shimizu, Stefano Salsano, Thomas Vachuska, Yi Tseng, Yuta Higuchi
Pier,

Thanks. This is great. Btw great timing, since the release planning will be today at 2pm pdt.

Can you please directly add the stories to the slide deck?

Thanks!

-Luca

To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deploym...@onosproject.org.
To post to this group, send email to brigade-d...@onosproject.org.



--
Luca Prete
Open Networking Foundation

--
You received this message because you are subscribed to the Google Groups "ONOS Deployments Brigade" group.
To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deploym...@onosproject.org.
To post to this group, send email to brigade-d...@onosproject.org.

Pier Luigi Ventre

unread,
Sep 5, 2017, 1:02:05 PM9/5/17
to Luca Prete, Andrea Campanella, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Sho Shimizu, Stefano Salsano, Thomas Vachuska, Yi Tseng, Yuta Higuchi
Done,
ONOS-7003 and ONOS-7004 has been added to the Platform sprint. I didn’t find brigades sprints in Jira.
Let me know if I have to move these items to another sprint.

Thanks
Pier

Luca Prete

unread,
Sep 5, 2017, 1:09:27 PM9/5/17
to Pier Luigi Ventre, Andrea Campanella, Brian O'Connor, Northbound brigade, ONOS Deployments Brigade, Sho Shimizu, Stefano Salsano, Thomas Vachuska, Yi Tseng, Yuta Higuchi
Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deployments+unsub...@onosproject.org.
To post to this group, send email to brigade-deployments@onosproject.org.



--
Luca Prete
Open Networking Foundation

--
You received this message because you are subscribed to the Google Groups "ONOS Deployments Brigade" group.
To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deployments+unsub...@onosproject.org.
To post to this group, send email to brigade-deployments@onosproject.org.
--
Luca Prete
Open Networking Foundation

--
You received this message because you are subscribed to the Google Groups "ONOS Deployments Brigade" group.
To unsubscribe from this group and stop receiving emails from it, send an email to brigade-deployments+unsub...@onosproject.org.
To post to this group, send email to brigade-deployments@onosproject.org.
Reply all
Reply to author
Forward
0 new messages