New Module Proposals: Fenix, Focus for Android, and Android Components

1,067 views
Skip to first unread message

Matthew Tighe

unread,
Mar 14, 2024, 6:35:38 PMMar 14
to gover...@mozilla.org
I would like to propose three new modules: Fenix, Focus for Android, and Android Components. These modules are all being introduced as the Android team migrates their existing codebases from Github to Mozilla Central, and will be located in the existing mobile/android subdirectory.

These modules map to the existing structure of Firefox for Android - Fenix/Focus are the application layer above Android Components, a re-usable component library which sits on top of GeckoView, an existing module that serves as the intermediate layer between Gecko and Android.

Module proposal:

Name: Fenix
Description:  Android Project to build Firefox for Android
Owner:  Jeff Boek, Gabriel Luong
Peer(s):  Rahul Sainani, Roger Yang
Source Dir(s): mobile/android/fenix

Name: Focus for Android
Description:  Android Project to build Focus for Android
Owner:  Mihai Carareh, Roger Yang
Peer(s):  Gabriel Iorga
Source Dir(s): mobile/android/focus-android

Name: Android Components
Description:  A collection of independent, reusable Android library components to make it easier to build browsers and browser-like applications.
Owner:  Arturo Mejia Marmol, Matt Tighe
Peer(s):  Jon Almeida, Kayacan Kaya
Source Dir(s): mobile/android/android-components

Unless there are any objections, we'll create the modules with the above proposal a week from today.

Thanks,
Matt

Nick Alexander

unread,
Mar 18, 2024, 4:20:01 PMMar 18
to Matthew Tighe, gover...@mozilla.org
Hi Matthew, others,

On Thu, Mar 14, 2024 at 3:36 PM Matthew Tighe <mti...@mozilla.com> wrote:
I would like to propose three new modules: Fenix, Focus for Android, and Android Components. These modules are all being introduced as the Android team migrates their existing codebases from Github to Mozilla Central, and will be located in the existing mobile/android subdirectory.

These modules map to the existing structure of Firefox for Android - Fenix/Focus are the application layer above Android Components, a re-usable component library which sits on top of GeckoView, an existing module that serves as the intermediate layer between Gecko and Android.

First, congratulations to everybody involved in bringing all of the Android ecosystem into mozilla-central -- what a lift!

Two comments:

1.  As written, the GeckoView module will encompass all these new modules: see https://firefox-source-docs.mozilla.org/mots/index.html#core-geckoview, which lists `mobile/android/**`.  That seems incorrect.
2.  I think we *should* have some kind of "all the Android things" module owner, similar to how the TLMC owns top-level and there's a Firefox Desktop module that owns all of `browser/**`, etc.  (I don't see anything like this right now but of course I may have overlooked it.)

Thoughts?
Nick

Matthew Tighe

unread,
Mar 19, 2024, 6:10:03 PMMar 19
to gover...@mozilla.org, Nick Alexander, gover...@mozilla.org, Matthew Tighe

Hey Nick,

Thanks for the comments and congratulations!

As to your comments:
1. Thanks for your diligence here! This should be handled in the pre-prepared patch to update mots, where we've added the incoming directories to the excludes list for the existing GV module.
2. Our team agrees that we likely *should* have an "all the Android things" module owner, but for now we will plan on seeing how things on the ground sort themselves out before we make further changes. This will definitely be a future consideration.

Appreciate the feedback,
Matt
Reply all
Reply to author
Forward
0 new messages