Removing Services.jsm

70 views
Skip to first unread message

Tooru Fujisawa

unread,
Jul 3, 2022, 9:52:03 PM7/3/22
to dev-pl...@mozilla.org, firef...@mozilla.org
Hi everyone!

https://bugzilla.mozilla.org/show_bug.cgi?id=1667455 is going to remove Services.jsm and define `Services` global property on all privileged globals.
That means the statement like the following is no longer necessary (and doesn't work) once the patch lands.

const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");

Also, sandboxes will get `Services` global property if `wantComponents` option is true (it defaults to true).

If there's any out-of-tree code that needs to support both before/after binary, you could do something like the following

const Services = globalThis.Services || ChromeUtils.import("resource://gre/modules/Services.jsm").Services;

Tooru Fujisawa

unread,
Jul 11, 2022, 8:45:28 AM7/11/22
to dev-pl...@mozilla.org, firef...@mozilla.org
A part of https://bugzilla.mozilla.org/show_bug.cgi?id=1667455 patch stack is going to be landed shortly, that removes all in-tree `Services.jsm` consumers,
while keeping `Services.jsm` file itself in tree, due to dependency from in-tree signed quitter.xpi (https://bugzilla.mozilla.org/show_bug.cgi?id=1777906).

The remaining patches that removes `Services.jsm` file will be landed shortly after the quitter.xpi gets updated.

2022/07/04 10:51、Tooru Fujisawa <arai....@gmail.com>のメール:

Rob Wu

unread,
Jul 11, 2022, 9:05:33 AM7/11/22
to Tooru Fujisawa, dev-pl...@mozilla.org, firef...@mozilla.org
Where is the bug that tracks the removal of the Services.jsm file?
There are still some out-of-tree uses of Services.jsm, and I'd like to make sure that there is an update plan for these before breaking these add-ons by the removal of Services.jsm.

--- Rob


--
You received this message because you are subscribed to the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/705439EA-0B6F-4EE2-94DF-44AF72DA21A4%40gmail.com.

Dave Townsend

unread,
Jul 11, 2022, 9:44:46 AM7/11/22
to Rob Wu, Tooru Fujisawa, dev-pl...@mozilla.org, Firefox Dev

Tooru Fujisawa

unread,
Jul 11, 2022, 10:34:13 AM7/11/22
to Dave Townsend, Rob Wu, dev-pl...@mozilla.org, Firefox Dev
Yes, https://bugzilla.mozilla.org/show_bug.cgi?id=1667455 is marked as leave-open,
and the Services.jsm removal is going to be landed there as well, as long as quitter.xpi update doesn't take long time
(otherwise it will be split into separate bug, to avoid spanning across releases).

About the out-of-tree consumers for Services.jsm, please refer https://bugzilla.mozilla.org/show_bug.cgi?id=1777486#c9

For privileged extensions, we've already submitted another announcement to authors, with privileged-extensions-specific info.

2022/07/11 22:44、Dave Townsend <dtow...@mozilla.com>のメール:

Tooru Fujisawa

unread,
Jul 21, 2022, 11:22:15 PM7/21/22
to Dave Townsend, Rob Wu, dev-pl...@mozilla.org, Firefox Dev
The Services.jsm file removal patches are moved to https://bugzilla.mozilla.org/show_bug.cgi?id=1780695,
and likely to be delayed to the next cycle (105).

2022/07/11 23:34、Tooru Fujisawa <arai....@gmail.com>のメール:

Tooru Fujisawa

unread,
Jul 5, 2023, 11:45:11 AM7/5/23
to Dave Townsend, Rob Wu, dev-pl...@mozilla.org, Firefox Dev
Hi all!

Finally Services.jsm is going to be remove in the 117 cycle.


If there's any remaining Services.jsm consumer and needs help rewriting, please reach me!

For Thunderbird extension authors, I've posted some instructions in

-- 
arai

2022/07/22 12:22、Tooru Fujisawa <arai....@gmail.com>のメール:
Reply all
Reply to author
Forward
0 new messages