OS.File Removal

17 views
Skip to first unread message

Barret Rennie

unread,
May 12, 2023, 9:02:59 PM5/12/23
to dev-platform, firef...@mozilla.org
Hi everyone,

Earlier today I landed a patch for bug 1776480 [1], which removes the vast majority of OS.File from the tree [2]. I wanted to say thank you to everyone who contributed patches or reviews to the effort.

-- Barret Rennie



[2]: See https://bugzilla.mozilla.org/show_bug.cgi?id=1786885 for follow-up removal of nsIOSFileConstantsService

Gijs Kruitbosch

unread,
May 15, 2023, 5:35:11 AM5/15/23
to Barret Rennie, dev-platform, firef...@mozilla.org

This is excellent news - and such an understated email for what has been a mammoth amount of work. Thank you, Barret, for persevering in the face of all the obstacles this threw up!

~ Gijs

--
You received this message because you are subscribed to the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/CA%2BSxwbeKrSdVe_2fv3DSjUvK3nCGewb9OsVoau_eg563Gf_KFA%40mail.gmail.com.

Mike Conley

unread,
May 15, 2023, 10:45:46 AM5/15/23
to Gijs Kruitbosch, Barret Rennie, dev-platform, firef...@mozilla.org
Echoing this. This is a very low-key status update for what was a pretty
monumental, multi-year task, and we shouldn't let it go by without
proper recognition.

This change is great because it gets rid of a web of JS that needed to
be parsed and compiled down early during startup (which is a time when
we need to be very selective about how much we read off of the disk and
where we lend CPU cycles). Besides this, I believe it also takes out a
big consumer of js-ctypes, which is (in general) a very good thing.

Wonderful work Barret, and to everybody who helped get this over the line!
>> https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/CA%2BSxwbeKrSdVe_2fv3DSjUvK3nCGewb9OsVoau_eg563Gf_KFA%40mail.gmail.com <https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/CA%2BSxwbeKrSdVe_2fv3DSjUvK3nCGewb9OsVoau_eg563Gf_KFA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "firef...@mozilla.org" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to firefox-dev...@mozilla.org
> <mailto:firefox-dev...@mozilla.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/mozilla.org/d/msgid/firefox-dev/6ce8bb87-4ead-747b-d115-3d675014ddf3%40mozilla.com <https://groups.google.com/a/mozilla.org/d/msgid/firefox-dev/6ce8bb87-4ead-747b-d115-3d675014ddf3%40mozilla.com?utm_medium=email&utm_source=footer>.
OpenPGP_0x58722F55DDDB00CE.asc
OpenPGP_signature
Reply all
Reply to author
Forward
0 new messages