Intent to ship: Popover Attribute

972 views
Skip to first unread message

Ziran Sun

unread,
Nov 29, 2023, 9:19:28 AM11/29/23
to dev-pl...@mozilla.org

Hi all,

As of Firefox 122, I intend to turn the Popover attribute on by default. 

It has been developed behind the dom.element.popover.enabled preference at https://bugzilla.mozilla.org/show_bug.cgi?id=1808823.

Status in other browsers is:
Chrome - supported since v114
Safari - supported since Safari Technology Preview 166 

Bug to turn on by default: https://bugzilla.mozilla.org/show_bug.cgi?id=1866993

Standard: https://html.spec.whatwg.org/#the-popover-attribute

Many thanks,

Ziran


Ziran Sun

unread,
Nov 29, 2023, 9:44:42 AM11/29/23
to dev-pl...@mozilla.org

Correcting the link -

Ziran

Emilio Cobos Álvarez

unread,
Nov 29, 2023, 11:32:13 AM11/29/23
to Ziran Sun, dev-pl...@mozilla.org
Hi Ziran,

Thanks for your work on this! Generally looks in pretty good shape.

I have a question about the tests. There are some existing tests here where our behavior (and WebKit's) diverges from Blink's. I don't think they block shipping necessarily since Safari is also shipping, but it'd be good to know if they are:
  1. Dependencies on other less mature specifications (like anchor positioning, popover=hint etc). It seems there are a couple like that.
  2. Issues with the test harness.
  3. Actual bugs (maybe low priority ones).
  4. Something else?
Would there be any chance of having a quick summary of those? At least for (2), (3) and (4) it'd be good to have bugs on file.

Assuming nothing problematic arises from that analysis, turning on by default and letting it ride the trains sounds good to me.

Thanks again!

 -- Emilio

--
You received this message because you are subscribed to the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/476fae4d-37af-4bf5-bd62-e737527a433e%40igalia.com.

Nicolas Chevobbe

unread,
Nov 29, 2023, 11:49:30 AM11/29/23
to dev-pl...@mozilla.org, zs...@igalia.com
Thanks for the Intent to shop Ziran.
I filed a couple of bugs for DevTools support:
- Bug 1867326 - Add beforetoggle and toggle event in the event listener breakpoints panel (not directly related, but made me realize we don't have those yet)

James Teh

unread,
Nov 29, 2023, 7:16:04 PM11/29/23
to Ziran Sun, dev-pl...@mozilla.org
Hi Ziran,
Does this implement any accessibility semantics? I believe Chrome implements some default accessibility semantics for popover. I'm not sure if these have been included in the spec yet, but I can find out from Chrome accessibility folks.
The general idea here is to ensure that popover has at least a basic level of accessibility exposure, even if an author failed to explicitly specify semantics. Of course, the author *should* specify semantics, but history dictates that many won't and we want to ensure users have reasonable access regardless.
Thanks!
Jamie

--
You received this message because you are subscribed to the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform...@mozilla.org.

Ziran Sun

unread,
Dec 1, 2023, 6:52:40 AM12/1/23
to Emilio Cobos Álvarez, dev-pl...@mozilla.org

Thanks Emilio!

Here are the bugs filed to summarize our test behavior that diverges from Blink's.

[1] Dependencies on other less mature specifications.

    * Bug 1867737 - Popover wpt test failures due to lack of Anchor positioning support

    * Bug 1867743 - support popover=hint. Not in spec and still in discussion(https://github.com/whatwg/html/pull/9778)

    * Bug 1867754 -  Support popover hover triggering on buttons.  Not in spec. It is mentioned here that this capability is gated behind the HTMLPopoverHint feature.

[2][3][4]:

    * Bug 1867755 -  popover-overlay.html fails due to lack of overlay support

Others:

   * There are also a couple of flat tree related tests that fail for all platforms. This is due to test_driver actions don't work on targets in shadow DOM. The bug is filed at Bug 1867756.

   * In the wpt.fyi link in your email, popover-events.html fails for Firefox. This is fixed at D195091 and hope to reflect on the result soon.


I think this has covered all the test failures we have at wpt.fyi for the moment. Do please let me know if you need any further information.

Many thanks,

Ziran

Ziran Sun

unread,
Dec 1, 2023, 11:03:43 AM12/1/23
to James Teh, dev-pl...@mozilla.org

Hi Jamie,

We haven't implemented any accessibility semantics. Thanks very much for bringing this up.

I filed a bug at here  and added you in the cc list.

Thanks,

Ziran

Ziran Sun

unread,
Feb 26, 2024, 3:26:54 PMFeb 26
to dev-pl...@mozilla.org, jt...@mozilla.com

Since the support for accessibility semantics is in (Thanks Jamie!), we are now enabling Popover attribute by default.

Bug: Bug 1866993 - Enable popover by default.

Specification: https://html.spec.whatwg.org/#the-popover-attribute

Platform coverage: all

Preference: dom.element.popover.enabled

Other browsers:

Chrome - supported since v114
Safari - supported since Safari Technology Preview 166 

web-platform-tests: WPT popover tests


Thanks!
Ziran
Reply all
Reply to author
Forward
0 new messages