Phabricator Data Reviews: remember to add the bug number

[Chris H-C]

Hello!

  All new or expanded data collection in Mozilla projects are subject to Data Collection Review[1], and if that project performs code review in Phabricator it gets to follow an expedited process[2].

  Part of what makes us confident in expediting these collections is that Data Stewardship conducts periodic audits of `data-classification-low`-marked data collections to ensure code authors and code reviewers are still accurate in their classification.

  And so far, so good! We've encountered very few instances where things ought to have been marked `data-collection-high`.

  One thing we have noticed, though, is that there are two kinds of code changes that forget to add the change's bug URL to the metric definitions:

1. Renewals, where all that changes is the expiry.

2. Additional extra keys being added to `event` metrics.

  Please be particularly particular about remembering to add your bug's URL to the list of bug URLs in the metrics definitions in those and all other cases where you're changing the data collection. It not only makes it easier to track changes, it makes the Data Stewardship audits faster to conduct.

Thanks!

:chutten

On behalf of the Data Stewardship Program

[1]: https://wiki.mozilla.org/Data_Collection

[2]: https://firefox-source-docs.mozilla.org/contributing/data-review.html