the world is safe once more for defineLazyPreferenceGetter

15 views

Skip to first unread message

Andrew McCreight

unread,

Oct 3, 2022, 10:12:43 AM10/3/22

to Firefox Dev

If you have had the misfortune of adding a call to XPCOMUtils.defineLazyPreferenceGetter() and getting weird a weird DOM assertion cache->PreservingWrapper() inside DOMJSProxyHandler.cpp (bug 1762665), I have fixed the underlying XPConnect issue that was causing this crash in bug 1543537, so you should be able to freely use defineLazyPreferenceGetter again without worrying.

I think this bug effectively dates to the introduction of the cycle collector around 2008, but it seems to have popped up occasionally starting around 2019. I'm sorry that it took me so long to fix. I've also reverted most of the workarounds in bug 1792457.