Crash Telemetry FontName/QuotaManagerShutdownTimeout fields

57 views
Skip to first unread message

Alex Franchuk

unread,
Apr 4, 2023, 10:58:12 AM4/4/23
to dev-pl...@mozilla.org
We are in the process of converting crash pings using legacy Telemetry to use Glean metrics/pings. We are also taking this as an opportunity to remove accrued cruft in the crash ping. See the full document for a breakdown.

What I'm wondering is whether anyone uses the following fields from legacy Telemetry crash pings:
FontName
QuotaManagerShutdownTImeout

If not, we will remove them for now (but we can always add them back or other details in the future!). Thanks!

Jeff Muizelaar

unread,
Apr 4, 2023, 11:25:57 AM4/4/23
to Alex Franchuk, dev-pl...@mozilla.org
We added FontName not that long ago to try to investigate a particular crash. It's hard to say if it will be useful in the future.

-Jeff

--
You received this message because you are subscribed to the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev-platform...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/952d202d-51a7-4615-9bf2-fe262c45dd3bn%40mozilla.org.

Alex Franchuk

unread,
Apr 4, 2023, 3:06:18 PM4/4/23
to Jeff Muizelaar, dev-pl...@mozilla.org

If it was added recently, that makes me more inclined to keep it. The worst we do is never use it (and possibly remove it in the future).

-Alex

Jan Varga

unread,
Apr 5, 2023, 2:08:59 PM4/5/23
to dev-pl...@mozilla.org


On 04/04/2023 16:58, Alex Franchuk wrote:
We are in the process of converting crash pings using legacy Telemetry to use Glean metrics/pings. We are also taking this as an opportunity to remove accrued cruft in the crash ping. See the full document for a breakdown.

What I'm wondering is whether anyone uses the following fields from legacy Telemetry crash pings:
FontName
QuotaManagerShutdownTImeout

QuotaManagerShutdownTImeout is used here:

https://searchfox.org/mozilla-central/rev/55d5c4b9dffe5e59eb6b019c1a930ec9ada47e10/dom/quota/ActorsParent.cpp#3385

It helps with investigating shutdown hangs.



If not, we will remove them for now (but we can always add them back or other details in the future!). Thanks!

Alex Franchuk

unread,
Apr 5, 2023, 2:36:50 PM4/5/23
to dev-pl...@mozilla.org

All right, it sounds like I'll keep both of these fields. Thanks all!

-Alex

You received this message because you are subscribed to a topic in the Google Groups "dev-pl...@mozilla.org" group.
To unsubscribe from this topic, visit https://groups.google.com/a/mozilla.org/d/topic/dev-platform/_qtiSdUXCpo/unsubscribe.
To unsubscribe from this group and all its topics, send an email to dev-platform...@mozilla.org.
To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/a169da4f-c422-b186-3ca5-64fd9b053378%40mozilla.com.

Jonathan Kew

unread,
Apr 7, 2023, 5:49:06 AM4/7/23
to dev-pl...@mozilla.org
On 04/04/2023 15:58, Alex Franchuk wrote:
> We are in the process of converting crash pings using legacy Telemetry
> to use Glean metrics/pings. We are also taking this as an opportunity to
> remove accrued cruft in the crash ping. See the full document
> <https://docs.google.com/document/d/1m1cgkvjg5e21JmQesrtupNgWZK7jzYYzF9YXBvBW03s> for a breakdown.
>
> What I'm wondering is whether anyone uses the following fields from
> legacy Telemetry crash pings:
> FontName

This was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1744135,
to try and diagnose font-related crashes we were seeing at that time.
AFAIK we're not currently seeing a lot of such issues, so I think we
could retire it for now.

(Unless Brad or folk from the gfx team feel we still want it...?)

> QuotaManagerShutdownTImeout
>
> If not, we will remove them for now (but we can always add them back or
> other details in the future!). Thanks!
>
> --
> You received this message because you are subscribed to the Google
> Groups "dev-pl...@mozilla.org" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to dev-platform...@mozilla.org
> <mailto:dev-platform...@mozilla.org>.
> To view this discussion on the web visit
> https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/952d202d-51a7-4615-9bf2-fe262c45dd3bn%40mozilla.org <https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/952d202d-51a7-4615-9bf2-fe262c45dd3bn%40mozilla.org?utm_medium=email&utm_source=footer>.

Reply all
Reply to author
Forward
0 new messages