[firefox-android] Updating editorconfig to match maxLineLength in detekt

15 views
Skip to first unread message

Jonathan Almeida

unread,
Jan 22, 2024, 4:46:51 PM1/22/24
to firefox...@mozilla.com
Hello all,

With bug 1875923, I have updated our editorconfig file to match the max line length settings that we use with detekt.

Android Studio and most major IDEs support editorconfig settings, so having one less configuration change needed for new contributors or fresh installs will make it easier for everyone to contribute.

Thanks!

-Jonathan A

Jonathan Almeida

unread,
Jan 26, 2024, 4:07:02 PM1/26/24
to firefox...@mozilla.com
ryanvm realized soon after this landed that there was a parsing issue with the config changes. Upon fixing this, the changes were then being consumed by ktlint that supports editorconfig too, where it analyzed a few more errors that we were not enforcing this rule.

For now, we have suppressed these errors with a baseline file as part of bug 1876419, with a follow-up bug 1876836 to consider globally running ktlintFormat.

Thanks Ryan for catching this!

Cheers,

-Jonathan A

Roger Yang

unread,
Jan 29, 2024, 5:48:03 PM1/29/24
to Public Firefox Mobile Group, Jonathan Almeida
Update.  After some discussion, we're going to revert this change (both the original and the followup change) until we're ready to do format all of the file at the same time as applying the editorconfig change.

Thanks,

-Roger
Reply all
Reply to author
Forward
0 new messages