Mathesar repository branch protections

[Zack Krida]

Hi team,

Earlier today Brent let me know about PR #4397, which was merged into `develop` with the SQL tests failing. Upon inspection, our branch protection rules for the `develop` and `master` branches did not include SQL test checks. I have added them now.

You can see the full list of required status checks for these branches below:

Please let me know if you encounter any issues with these new required status checks. Additionally, please let me know if there are other checks that should be required beyond the current set, for example the API scenario tests.

Best,

Zack

[Brent Moran]

I took a few minutes to look into this. The problem is deeper than I originally thought, and the solution of adding the SQL tests to the branch protections checks isn't sufficient. I created an issue with more details: https://github.com/mathesar-foundation/mathesar/issues/4405 . We should solve that ASAP.

[Brent Moran]

Update:

All required tests are now dependencies of the "checkpoint" job on GH actions:

The way it works is that the "checkpoint" job verifies that all upstream jobs either passed or were skipped. In that case, it passes. If any upstream job fails, it fails. So, branch protections now only check for that single job's success status. For any future jobs (that fit into the "test and lint code" framework), we should thus add them as dependencies for the "checkpoint" job, and verify they succeeded in the same way.  Relevant PRs:

https://github.com/mathesar-foundation/mathesar/pull/4411

https://github.com/mathesar-foundation/mathesar/pull/4413

Brent

[Zack Krida]

Thanks Brent! This is great because it means that for the most part, we can manage our branch protection rules programmatically rather than by fiddling with the GitHub UI. We won't have to sync changes in the code and in GitHub. Thanks to you and @Anish Umale for getting to the bottom of this.

--

Zack Krida

Technical Community Advocate | Mathesar

za...@mathesar.org | Schedule a call