Question about new component submission

[Florent GERMAIN]

Hello,
We are working on an external communication component.
We plan to work on an open version of this external communication component to test it outside of our infrastructure.

To use it with Open MPI, we developed a PML component (and are developing an OSC component).

We would like to submit them to the Open MPI community.

What is the procedure to submit these components?

What are the requirements for these components to be ?

Regards,

Florent GERMAIN Ingénieur de développement – BDS-R&D 2 rue de la Piquetterie – Bruyères le Chatel – France eviden.com

an atos business

 

 

[Gilles Gouaillardet]

Florent,

All you need is to issue a Pull Request and make sure the commits are signed off (and you understand the legal implications of doing that)

Cheers,

Gilles

To unsubscribe from this group and stop receiving emails from it, send an email to devel+un...@lists.open-mpi.org.

[Jeff Squyres (jsquyres)]

Additionally, we will want some assurances that you will continue to support the code over time.  We are not looking for one-time dumps of software solely for the purpose of getting the code in the main community distribution.

Can you give us a description of what these new PML and OSC components will do?  E.g., do they support some specific networking hardware?

---

From: Gilles Gouaillardet <gilles.go...@gmail.com>
Sent: Wednesday, January 22, 2025 9:00 AM
To: de...@lists.open-mpi.org <de...@lists.open-mpi.org>
Cc: dl-rd-herons <dl-rd-...@eviden.com>
Subject: Re: [OMPI devel] Question about new component submission

 

[Florent GERMAIN]

The external communication component is named UBCL.
It is the communication transport for our BXI interconnect for at least the coming years.

It has a shared memory transport (for now CMA and CUDA IPC) and a BXI interconnect transport.

Regards,

Florent

---

De : 'Jeff Squyres (jsquyres)' via Open MPI devel <de...@lists.open-mpi.org>
Envoyé : mercredi 22 janvier 2025 15:18
À : de...@lists.open-mpi.org <de...@lists.open-mpi.org>
Cc : dl-rd-herons <dl-rd-...@eviden.com>
Objet : Re: [OMPI devel] Question about new component submission

 

[George Bosilca]

Florent,

With such specific hardware needs the community would not be able to provide any guarantee (compile or test) about these component. Are you planning to join our github CI or at least the MTT tester in order to ensure correctness of the two proposed components ?

Best,

George.

[Howard Pritchard]

Hello Florent,

Would you be opening a PR for both PML and OSC components?  The reason I ask is if you don’t have the OSC component ready to include in a PR how will you be supporting one sided ops?  

Would your PRs touch code outside of the new components?   

Also it would be nice to add some documentation about the BXI network in for example the docs/installing-open-mpi/configure-cli-options/networking.rst  file in the docs folder.  Also double check if there may need to be updates to fork-system-popen.rst.

If the BXI  transport API is using some portals API there are additional things to consider.  Actually I thought BXI used to talk portals4.  Is there a reason you can't use the existing portals4 mtl and osc components?

George's points on testing, ideally CI, are quite important.

 Howard

[Florent GERMAIN]

We plan to develop this year an open-source based transport (likely tcp) to allow UBCL to run on various machines.

We need to check what is possible regarding CI and MTT on our side.

Regards,

Florent

---

De : 'George Bosilca' via Open MPI devel <de...@lists.open-mpi.org>
Envoyé : mercredi 22 janvier 2025 16:34

[Florent GERMAIN]

Hello,

Would you be opening a PR for both PML and OSC components?
The reason I ask is if you don’t have the OSC component ready to include in a PR how will you be supporting one sided ops?

As pt2pt osc has been dropped, we need both pml and osc, thus our intent is to open a PR for each of these two components at the same time.
Is your recommendation to actually open a single PR for both?

 

Would your PRs touch code outside of the new components?

I don't think we have any modification outside of than pml+osc+common components.

 

Also it would be nice to add some documentation about the BXI network in for example the docs/installing-open-mpi/configure-cli-options/networking.rst  file in the docs folder.  Also double check if there may need to be updates to fork-system-popen.rst.

We'll check these files.

If the BXI  transport API is using some portals API there are additional things to consider.  Actually I thought BXI used to talk portals4. Is there a reason you can't use the existing portals4 mtl and osc components?

BXI hardware is indeed based on portals4 API. The main reason why we use an external component is to plug it in other communication frameworks like for example NCCL/RCCL. Is is also easier to optimize the communication protocols regarding BXI hardware. We also can benefit shared memory under some conditions, which seems to be harder using the portals4 mtl.

Regards,
Florent

---

De : Howard Pritchard <hppr...@gmail.com>
Envoyé : mercredi 22 janvier 2025 17:16
À : de...@lists.open-mpi.org <de...@lists.open-mpi.org>

[Howard Pritchard]

Hello Florent,

Am Do., 23. Jan. 2025 um 01:24 Uhr schrieb 'Florent GERMAIN' via Open MPI devel <de...@lists.open-mpi.org>:

Hello,

Would you be opening a PR for both PML and OSC components?
The reason I ask is if you don’t have the OSC component ready to include in a PR how will you be supporting one sided ops?

As pt2pt osc has been dropped, we need both pml and osc, thus our intent is to open a PR for each of these two components at the same time.
Is your recommendation to actually open a single PR for both?

 

 

That would be better.  

Would your PRs touch code outside of the new components?

I don't think we have any modification outside of than pml+osc+common components.

 

 

Very good!

Also it would be nice to add some documentation about the BXI network in for example the docs/installing-open-mpi/configure-cli-options/networking.rst  file in the docs folder.  Also double check if there may need to be updates to fork-system-popen.rst.

We'll check these files.

If the BXI  transport API is using some portals API there are additional things to consider.  Actually I thought BXI used to talk portals4. Is there a reason you can't use the existing portals4 mtl and osc components?

BXI hardware is indeed based on portals4 API. The main reason why we use an external component is to plug it in other communication frameworks like for example NCCL/RCCL. Is is also easier to optimize the communication protocols regarding BXI hardware. We also can benefit shared memory under some conditions, which seems to be harder using the portals4 mtl.

Ah that makes sense, esp. the shared memory part.