Re: [PATCH v2 7/7] usb: fix UAF when probe runs concurrent to dyn ID removal
0 views
Skip to first unread message
Danilo Krummrich
Jul 7, 2026, 12:05:49 PM (3 days ago) Jul 7
to Gary Guo, Greg Kroah-Hartman, Rafael J. Wysocki, Toke Høiland-Jørgensen, Johan Hovold, Mauro Carvalho Chehab, Petko Manolov, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Chas Williams, Alan Stern, linu...@vger.kernel.org, drive...@lists.linux.dev, linux-w...@vger.kernel.org, linux...@vger.kernel.org, linux-at...@lists.sourceforge.net, net...@vger.kernel.org, usb-s...@lists.one-eyed-alien.net, linux-...@vger.kernel.org
On 7/7/26 2:26 PM, Gary Guo wrote:
> Dynamic IDs are only guaranteed to be valid when usb_dynids_lock is held,
> as remove_id_store can free the node. Thus, make a copy in
> usb_probe_interface. Clarify the documentation that the id parameter is
> only valid during the probe.
>
> USB serial has the same pattern, but it does not need fixing as the IDs
> cannot be removed via sysfs.
>
> Fixes: 0c7a2b72746a ("USB: add remove_id sysfs attr for usb drivers")
> Signed-off-by: Gary Guo <ga...@garyguo.net>
Reviewed-by: Danilo Krummrich <da...@kernel.org>
> Dynamic IDs are only guaranteed to be valid when usb_dynids_lock is held,
> as remove_id_store can free the node. Thus, make a copy in
> usb_probe_interface. Clarify the documentation that the id parameter is
> only valid during the probe.
>
> USB serial has the same pattern, but it does not need fixing as the IDs
> cannot be removed via sysfs.
>
> Fixes: 0c7a2b72746a ("USB: add remove_id sysfs attr for usb drivers")
> Signed-off-by: Gary Guo <ga...@garyguo.net>
Reviewed-by: Danilo Krummrich <da...@kernel.org>
Reply all
Reply to author
Forward
0 new messages