[PATCH 1/1] usb-storage: Add unusual-devs entry for Novatek NTK96550-based camera

[Mael GUERIN]

Signed-off-by: Mael GUERIN <mael....@murena.io>
---
drivers/usb/storage/unusual_devs.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 54f0b1c83..7bb5a1d75 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -262,6 +262,13 @@ UNUSUAL_DEV( 0x0421, 0x06c2, 0x0000, 0x0406,
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
US_FL_MAX_SECTORS_64 ),

+/* Added by Maël GUERIN <mael....@murena.io> */
+UNUSUAL_DEV( 0x0603, 0x8611, 0x0000, 0xffff,
+ "Novatek",
+ "NTK96550-based camera",
+ USB_SC_SCSI, USB_PR_BULK, NULL,
+ US_FL_BULK_IGNORE_TAG ),
+
#ifdef NO_SDDR09
UNUSUAL_DEV( 0x0436, 0x0005, 0x0100, 0x0100,
"Microtech",
--
2.50.1

[Alan Stern]

On Wed, Aug 06, 2025 at 03:47:21PM +0200, Mael GUERIN wrote:
> Signed-off-by: Mael GUERIN <mael....@murena.io>
> ---

Patches must have a nonempty description. You can simply take the text
of your 0/1 message and put it directly in the 1/1 email as the
description. Then there won't be any need for a separate 0/1 message.

> drivers/usb/storage/unusual_devs.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 54f0b1c83..7bb5a1d75 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -262,6 +262,13 @@ UNUSUAL_DEV( 0x0421, 0x06c2, 0x0000, 0x0406,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_MAX_SECTORS_64 ),
>
> +/* Added by Maël GUERIN <mael....@murena.io> */
> +UNUSUAL_DEV( 0x0603, 0x8611, 0x0000, 0xffff,
> + "Novatek",
> + "NTK96550-based camera",
> + USB_SC_SCSI, USB_PR_BULK, NULL,
> + US_FL_BULK_IGNORE_TAG ),

See the instructions at the start of this file. Entries are supposed to
be sorted by Vendor ID and then Product ID.

Alan Stern

[Mael GUERIN]

Add the US_FL_BULK_IGNORE_TAG quirk for Novatek NTK96550-based camera
to fix USB resets after sending SCSI vendor commands due to CBW and
CSW tags difference, leading to undesired slowness while communicating
with the device.

Please find below the copy of /sys/kernel/debug/usb/devices with my
device plugged in (listed as TechSys USB mass storage here, the
underlying chipset being the Novatek NTK96550-based camera):

T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=0603 ProdID=8611 Rev= 0.01
S: Manufacturer=TechSys
S: Product=USB Mass Storage
S: SerialNumber=966110000000100
C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

Signed-off-by: Mael GUERIN <mael....@murena.io>
---

Thanks for your review and your advice. Here's the updated version of the
patch with a correct description as well as the unusual_devs.h file sorted
correctly.

drivers/usb/storage/unusual_devs.h | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h

index 54f0b1c83..bee9f1e80 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -934,6 +934,13 @@ UNUSUAL_DEV( 0x05e3, 0x0723, 0x9451, 0x9451,
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
US_FL_SANE_SENSE ),

+/* Added by Maël GUERIN <mael....@murena.io> */
+UNUSUAL_DEV( 0x0603, 0x8611, 0x0000, 0xffff,
+ "Novatek",
+ "NTK96550-based camera",
+ USB_SC_SCSI, USB_PR_BULK, NULL,
+ US_FL_BULK_IGNORE_TAG ),
+

/*
* Reported by Hanno Boeck <ha...@gmx.de>
* Taken from the Lycoris Kernel
--
2.50.1

[Alan Stern]

The Subject line really ought to say "USB: storage: Add ..." but that's
a very minor matter; Greg can adjust it if he wants when the patch is
applied.

Apart from that...

Acked-by: Alan Stern <st...@rowland.harvard.edu>

Alan Stern