Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[lxc/lxc] dc4df2: lxc/lxccontainer: specify file mode in open() call...

0 views
Skip to first unread message

Christian Brauner

unread,
Apr 2, 2024, 8:55:40 AM4/2/24
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/main
Home: https://github.com/lxc/lxc
Commit: dc4df233595daa1b6eaa5a18d495b0a995660f7f
https://github.com/lxc/lxc/commit/dc4df233595daa1b6eaa5a18d495b0a995660f7f
Author: Alexander Mikhalitsyn <aleksandr....@canonical.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/lxccontainer.c

Log Message:
-----------
lxc/lxccontainer: specify file mode in open() call inside mod_rdep

We must explicitly specify file mode in open(.. O_CREAT ..).

Let's set 0644, while previously it was 0666 [1] which seems too much.

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=libio/fileops.c;h=4db4a76f755b1f3b766dc47c669c09242395ec95;hb=HEAD#l216

Fixes: Coverity 1596044
Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: 17aaada7c7ec434668399ab87d5e81a2a5d78715
https://github.com/lxc/lxc/commit/17aaada7c7ec434668399ab87d5e81a2a5d78715
Author: Christian Brauner <chri...@brauner.io>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/lxccontainer.c

Log Message:
-----------
Merge pull request #4419 from mihalicyn/fixup_mod_rdep

lxc/lxccontainer: specify file mode in open() call inside mod_rdep


Compare: https://github.com/lxc/lxc/compare/80e28c1fe9db...17aaada7c7ec

To unsubscribe from these emails, change your notification settings at https://github.com/lxc/lxc/settings/notifications
Reply all
Reply to author
Forward
0 new messages