[lxc/lxc] ad8f55: tree-wide: replace multiply_overflow with check_mu...

2 views
Skip to first unread message

Stéphane Graber

unread,
Apr 2, 2024, 9:06:17 AMApr 2
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/main
Home: https://github.com/lxc/lxc
Commit: ad8f554458d1e93bd5dbde7ed650cb24a5401ce3
https://github.com/lxc/lxc/commit/ad8f554458d1e93bd5dbde7ed650cb24a5401ce3
Author: Arnaud Fontaine <arnaud....@airbus.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/confile.c
M src/lxc/utils.c
M src/lxc/utils.h

Log Message:
-----------
tree-wide: replace multiply_overflow with check_mul_overflow

Remove redundant multiply_overflow helper and use check_mul_overflow.

This also fixes a bug with incorrect handling for negative offset values.

Link: #4374

Signed-off-by: Arnaud Fontaine <arnaud....@airbus.com>
Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: 6fea674291b985baac026dc60e2e10f219587d00
https://github.com/lxc/lxc/commit/6fea674291b985baac026dc60e2e10f219587d00
Author: Alexander Mikhalitsyn <aleksandr....@canonical.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/tests/parse_config_file.c

Log Message:
-----------
tests/parse_config_file: add tests for lxc.time.offset.*

Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: dcc4fb929434b741992cc166a7cb89540ca71abe
https://github.com/lxc/lxc/commit/dcc4fb929434b741992cc166a7cb89540ca71abe
Author: Alexander Mikhalitsyn <aleksandr....@canonical.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/tests/parse_config_file.c

Log Message:
-----------
tests/parse_config_file: fix some typos

Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: 796f2ccb74d8e951d549ce39b139d47abfefb87e
https://github.com/lxc/lxc/commit/796f2ccb74d8e951d549ce39b139d47abfefb87e
Author: Alexander Mikhalitsyn <aleksandr....@canonical.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/confile.c

Log Message:
-----------
lxc/confile: do not print newline symbol in getter for lxc.time.offset.*

It's clearly a mistake in the getters implementation.

Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: 630b46ed281fbfd068657b7e4bbed1675d28b2e5
https://github.com/lxc/lxc/commit/630b46ed281fbfd068657b7e4bbed1675d28b2e5
Author: Alexander Mikhalitsyn <aleksandr....@canonical.com>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/confile.c

Log Message:
-----------
lxc/confile: do not print excess space before scale suffix for time.offset.boot

Let's make time.offset.boot and time.offset.monotonic getters consistent

Signed-off-by: Alexander Mikhalitsyn <aleksandr....@canonical.com>


Commit: b0fd9a9d2b6b6d891c50988d683624a88779c1a4
https://github.com/lxc/lxc/commit/b0fd9a9d2b6b6d891c50988d683624a88779c1a4
Author: Stéphane Graber <stgr...@stgraber.org>
Date: 2024-04-02 (Tue, 02 Apr 2024)

Changed paths:
M src/lxc/confile.c
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/parse_config_file.c

Log Message:
-----------
Merge pull request #4418 from mihalicyn/cumulative_fixes_2apr2024

confile_utils: fix incorrect multiply_overflow test #2


Compare: https://github.com/lxc/lxc/compare/b7707ce398ac...b0fd9a9d2b6b

To unsubscribe from these emails, change your notification settings at https://github.com/lxc/lxc/settings/notifications
Reply all
Reply to author
Forward
0 new messages