[lxc/lxc] b7affe: lxc-checkconfig: Only check probed modules if /pro...

5 views
Skip to first unread message

Stéphane Graber

unread,
Mar 9, 2022, 11:14:27 AM3/9/22
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: b7affe5264c5405137389e1cd6fbda5cc4208c05
https://github.com/lxc/lxc/commit/b7affe5264c5405137389e1cd6fbda5cc4208c05
Author: Jami Kettunen <jami.k...@protonmail.com>
Date: 2022-03-08 (Tue, 08 Mar 2022)

Changed paths:
M src/lxc/cmd/lxc-checkconfig.in

Log Message:
-----------
lxc-checkconfig: Only check probed modules if /proc/modules exists

Kernels can be built with CONFIG_MODULES=n which results in
is_probed() telling the module isn't probed and lsmod spamming the
following to stderr each time it's called:

libkmod: kmod_module_new_from_loaded: could not open /proc/modules: No such file or directory
Error: could not get list of modules: No such file or directory

Fix this by "stubbing" is_probed() when /proc/modules doesn't exist
as it's always called after a is_enabled() anyway.

Signed-off-by: Jami Kettunen <jami.k...@protonmail.com>


Commit: 30ebf0964d7ae3e2a76c5885e652c775ea591bc9
https://github.com/lxc/lxc/commit/30ebf0964d7ae3e2a76c5885e652c775ea591bc9
Author: Stéphane Graber <stgr...@ubuntu.com>
Date: 2022-03-09 (Wed, 09 Mar 2022)

Changed paths:
M src/lxc/cmd/lxc-checkconfig.in

Log Message:
-----------
Merge pull request #4091 from JamiKettunen/non-modular-kernels

lxc-checkconfig: Only check probed modules if /proc/modules exists


Compare: https://github.com/lxc/lxc/compare/2ff64429ecd0...30ebf0964d7a
Reply all
Reply to author
Forward
0 new messages