[lxc/lxc] d3162e: oss-fuzz: always turn off logging on OSS-Fuzz

0 views
Skip to first unread message

Christian Brauner

unread,
May 4, 2021, 11:44:55 AM (11 days ago) May 4
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/stable-4.0
Home: https://github.com/lxc/lxc
Commit: d3162efaa1adbcb9b4e960413440b80fbe0fd5a2
https://github.com/lxc/lxc/commit/d3162efaa1adbcb9b4e960413440b80fbe0fd5a2
Author: Evgeny Vereshchagin <evv...@ya.ru>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M configure.ac
M src/lxc/log.c

Log Message:
-----------
oss-fuzz: always turn off logging on OSS-Fuzz

Apparently /proc/self/cmd can't be used (reliably) on OSS-Fuzz to figure out
whether the code is run inside the fuzz targets, which causes the
fuzz targets to fill the filesystem with log files.

Related: https://github.com/google/oss-fuzz/issues/5509
Should address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33835

Signed-off-by: Evgeny Vereshchagin <evv...@ya.ru>


Commit: bdd90796f82a9f6538c7bf2476373de2af5e727f
https://github.com/lxc/lxc/commit/bdd90796f82a9f6538c7bf2476373de2af5e727f
Author: Aaron Thompson <d...@aaront.org>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/conf.c

Log Message:
-----------
conf: fix console chmod error log messages

Signed-off-by: Aaron Thompson <d...@aaront.org>


Commit: fb831517774279f5428f49b9abd62800e19abda6
https://github.com/lxc/lxc/commit/fb831517774279f5428f49b9abd62800e19abda6
Author: Stéphane Graber <stgr...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M .github/workflows/sanitizers.sh

Log Message:
-----------
github: Run apt-get update in sanitizer test

Signed-off-by: Stéphane Graber <stgr...@ubuntu.com>


Commit: f0292a36f2b49a6072f78039e3a80445c4fad804
https://github.com/lxc/lxc/commit/f0292a36f2b49a6072f78039e3a80445c4fad804
Author: Evgeny Vereshchagin <evv...@ya.ru>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M .github/workflows/sanitizers.sh

Log Message:
-----------
github: remove the dh-* packages

We don't build any packages there so it seems we don't need
those packages any more. Apart from that, it should make the
script work on Ubuntu Hirsute where dh-systemd was merged into
debhelper and is no longer available.

Signed-off-by: Evgeny Vereshchagin <evv...@ya.ru>


Commit: 15e2d139c70651e7863fd3814f1c49620203392c
https://github.com/lxc/lxc/commit/15e2d139c70651e7863fd3814f1c49620203392c
Author: Evgeny Vereshchagin <evv...@ya.ru>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M .github/workflows/sanitizers.sh

Log Message:
-----------
github: also pass the j option to make

Signed-off-by: Evgeny Vereshchagin <evv...@ya.ru>


Commit: 4056542b51a2e698daba224287b34513b655261c
https://github.com/lxc/lxc/commit/4056542b51a2e698daba224287b34513b655261c
Author: Evgeny Vereshchagin <evv...@ya.ru>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/string_utils.c

Log Message:
-----------
string_utils: get around GCC-11 false positives

by getting rid of stpncpy

Tested with gcc (GCC) 11.1.1 20210428 (Red Hat 11.1.1-1)

Closes https://github.com/lxc/lxc/issues/3752

Signed-off-by: Evgeny Vereshchagin <evv...@ya.ru>


Commit: 2c1754e3e31da92cf65c0fde39bdfff6ccc79164
https://github.com/lxc/lxc/commit/2c1754e3e31da92cf65c0fde39bdfff6ccc79164
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/confile.c

Log Message:
-----------
confile: make per_name struct static

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 9cc5d48b3fbe70edf0dfcde90d096dc9b6f211e3
https://github.com/lxc/lxc/commit/9cc5d48b3fbe70edf0dfcde90d096dc9b6f211e3
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/commands.c

Log Message:
-----------
commands: log at debug not info level when receiving file descriptors

Don't spam the logs because we do receive a lot of file descriptors.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 7389642a70bb5eced75f7ceb7fc4065405802202
https://github.com/lxc/lxc/commit/7389642a70bb5eced75f7ceb7fc4065405802202
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/macro.h
M src/lxc/syscall_numbers.h
M src/lxc/syscall_wrappers.h

Log Message:
-----------
syscalls: wrap personality syscall if undefined

There's no need to making personality handling conditional as it has
been around for such a long time that only weird systems wouldn't have
support for it. And especially if the user requested a specific
personality to be set but the system doesn't support the personality
syscall we should loudly fail instead of moving on.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 5ae15884c9003c95c0b5c5df24c8868b8f83d9ea
https://github.com/lxc/lxc/commit/5ae15884c9003c95c0b5c5df24c8868b8f83d9ea
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/attach.c
M src/lxc/conf.c
M src/lxc/confile.c
M src/lxc/syscall_wrappers.h

Log Message:
-----------
tree-wide: make personality codepaths unconditional

Now that we have the infra to make personality handling unconitional
remove the ifndefs everywhere.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 77f626c571df2276de8109d3be1d6a8458a0e75c
https://github.com/lxc/lxc/commit/77f626c571df2276de8109d3be1d6a8458a0e75c
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/conf.c

Log Message:
-----------
conf: tweak setup_personality()

Use the dedicated LXC_ARCH_UNCHANGED macro everywhere instead of relying
on -1 being correct.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 2ce89d7ff140c1a9dcaf8b1fdb161565f7915e74
https://github.com/lxc/lxc/commit/2ce89d7ff140c1a9dcaf8b1fdb161565f7915e74
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/attach.c
M src/lxc/confile.c
M src/lxc/confile.h
M src/lxc/tools/lxc_attach.c

Log Message:
-----------
conf: rework lxc_config_parse_arch()

Fix architecture parsing. So far we couldn't really differ between "want
default architecture" and "failed to parse requested architecture"
because the -1 return value means both. Fix this by using the return
value only to indicate success or failure and return the parsed
personality in a return argument.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 70cf146177ac34451d92a1f797f431bbff6d8f6e
https://github.com/lxc/lxc/commit/70cf146177ac34451d92a1f797f431bbff6d8f6e
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/attach_options.h

Log Message:
-----------
attach_options: unbreak header

In a moment of idioticity I switch -1 with 0xffffffff in the header
definition but we use -1 to autodetect.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 84fc7c27b76e64e4d7356bc2347c998d96eb236d
https://github.com/lxc/lxc/commit/84fc7c27b76e64e4d7356bc2347c998d96eb236d
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/attach.c
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/confile.c

Log Message:
-----------
conf: add personality_t

Catch errors in personality handling better.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 97d46fd372a50c0dbedd09b5fb712cef50b9fc42
https://github.com/lxc/lxc/commit/97d46fd372a50c0dbedd09b5fb712cef50b9fc42
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-05-04 (Tue, 04 May 2021)

Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h

Log Message:
-----------
attach: introduce explicit personality macro

Introduce LXC_ATTACH_DETECT_PERSONALITY to make it explicit what is
happening instead of using -1.

Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/c53580ec51e5...97d46fd372a5
Reply all
Reply to author
Forward
0 new messages