[lxc/lxc] c18430: start: fix logging message

0 views
Skip to first unread message

Christian Brauner

unread,
Jul 15, 2021, 3:55:28 PM (8 days ago) Jul 15
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/stable-4.0
Home: https://github.com/lxc/lxc
Commit: c18430b0010162c30535191eca6bb2bfd6c92819
https://github.com/lxc/lxc/commit/c18430b0010162c30535191eca6bb2bfd6c92819
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-07-15 (Thu, 15 Jul 2021)

Changed paths:
M src/lxc/start.c

Log Message:
-----------
start: fix logging message

Fixes: #3875
Suggested-by: Hank.shi <shk2...@163.com>
Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 401e36705c2bde6ea934dcf3632a39a120767a27
https://github.com/lxc/lxc/commit/401e36705c2bde6ea934dcf3632a39a120767a27
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-07-15 (Thu, 15 Jul 2021)

Changed paths:
M src/lxc/sync.c

Log Message:
-----------
sync: fix log message

Fixes: #3875
Suggested-by: Hank.shi <shk2...@163.com>
Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: 0b9a29b541f2130dd363fed34996c2918285374d
https://github.com/lxc/lxc/commit/0b9a29b541f2130dd363fed34996c2918285374d
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-07-15 (Thu, 15 Jul 2021)

Changed paths:
M src/lxc/terminal.c

Log Message:
-----------
terminal: log TIOCGPTPEER failure less alarmingly

This is not a fatal error and the fallback codepath is equally safe.
When we use TIOCGPTPEER we're using a stashed fd to the container's
devpts mount's ptmx device and allocating a new fd non-path based
through this ioctl. If this ioctl can't be used we're falling back to
allocating a pts device from the host's devpts mount's ptmx device which
is path-based but is not under control of the container and so that's
safe. The difference is just that the first method gets you a nice
native terminal with all the pleasantries of having tty and friends
working whereas the latter method does not.

Fixes: #3625
Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Commit: e3e69becce07904719d2847b8060ef295475ce35
https://github.com/lxc/lxc/commit/e3e69becce07904719d2847b8060ef295475ce35
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2021-07-15 (Thu, 15 Jul 2021)

Changed paths:
M src/lxc/af_unix.c

Log Message:
-----------
af_unix: report error when no fd is to be sent

Fixes: #3624
Signed-off-by: Christian Brauner <christia...@ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/115c82315145...e3e69becce07
Reply all
Reply to author
Forward
0 new messages