[lxc/lxc] e6ad17: start: Remove outdated comment about group dropping

0 views
Skip to first unread message

Stéphane Graber

unread,
Dec 15, 2025, 9:46:27 PM (2 days ago) Dec 15
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/main
Home: https://github.com/lxc/lxc
Commit: e6ad17a796ae056337744980fb0719607a6be985
https://github.com/lxc/lxc/commit/e6ad17a796ae056337744980fb0719607a6be985
Author: Filip Schauer <f.sc...@proxmox.com>
Date: 2025-12-15 (Mon, 15 Dec 2025)

Changed paths:
M src/lxc/start.c

Log Message:
-----------
start: Remove outdated comment about group dropping

Commit b58214ac30bd (tree-wide: improve setgroups() dropping) moved the
group dropping code to occur before lxc_switch_uid_gid. Therefore this
comment is no longer correct.

Signed-off-by: Filip Schauer <f.sc...@proxmox.com>


Commit: 9e6caeabec77471c46a629ad5a5a6586ff31e9ce
https://github.com/lxc/lxc/commit/9e6caeabec77471c46a629ad5a5a6586ff31e9ce
Author: Filip Schauer <f.sc...@proxmox.com>
Date: 2025-12-15 (Mon, 15 Dec 2025)

Changed paths:
M src/lxc/start.c

Log Message:
-----------
start: Respect lxc.init.groups also in new user namespace

Fix supplementary groups defined in 'lxc.init.groups' being ignored when
the container uses a new user namespace.

In other words: Fix lxc.init.groups for unprivileged containers.

Signed-off-by: Filip Schauer <f.sc...@proxmox.com>


Commit: 27e8823a224cbd4598ab25b5fe4c1614a14b1afe
https://github.com/lxc/lxc/commit/27e8823a224cbd4598ab25b5fe4c1614a14b1afe
Author: Stéphane Graber <stgr...@stgraber.org>
Date: 2025-12-15 (Mon, 15 Dec 2025)

Changed paths:
M src/lxc/start.c

Log Message:
-----------
Merge pull request #4626 from Filiprogrammer/fix-init-groups-in-userns

Do not ignore lxc.init.groups when using userns


Compare: https://github.com/lxc/lxc/compare/e59aea2dd7ff...27e8823a224c

To unsubscribe from these emails, change your notification settings at https://github.com/lxc/lxc/settings/notifications
Reply all
Reply to author
Forward
0 new messages