[lxc/lxc] 4ebca5: lxc-attach: Fix lost return codes of spawned proce...

0 views
Skip to first unread message

Christian Brauner

unread,
Oct 19, 2022, 7:01:18 AM10/19/22
to lxc-...@lists.linuxcontainers.org
Branch: refs/heads/master
Home: https://github.com/lxc/lxc
Commit: 4ebca5a005afbc19c08f663e24d3e76518d12fa8
https://github.com/lxc/lxc/commit/4ebca5a005afbc19c08f663e24d3e76518d12fa8
Author: Mohammed Ajmal Siddiqui <ajmalsi...@gmail.com>
Date: 2022-10-05 (Wed, 05 Oct 2022)

Changed paths:
M src/lxc/tools/lxc_attach.c

Log Message:
-----------
lxc-attach: Fix lost return codes of spawned processes that are killed

lxc-attach swallows the return codes of processes that are terminated
via a signal, and by default exits with a return code of 0 (i.e.
indicating success) even if the command it tried to execute was
terminated.

This patch fixes it by explicitly checking if the process was terminated
via a signal, and returning an appropriate exit code.

Note that we add 128 to the signal value to generate the exit code
because by convention the exit code is 128 + signal number. e.g. if a
process is killed via signal 9, then the error code is 9 + 128 = 137.

Signed-off-by: Mohammed Ajmal Siddiqui <ajmalsi...@gmail.com>


Commit: fbed9bb75980e96c18c02924d6584a5660e186ac
https://github.com/lxc/lxc/commit/fbed9bb75980e96c18c02924d6584a5660e186ac
Author: Christian Brauner <christia...@ubuntu.com>
Date: 2022-10-19 (Wed, 19 Oct 2022)

Changed paths:
M src/lxc/tools/lxc_attach.c

Log Message:
-----------
Merge pull request #4204 from ajmalsiddiqui/master

lxc-attach: Fix lost return codes of spawned processes that are killed


Compare: https://github.com/lxc/lxc/compare/bff4223cd8da...fbed9bb75980
Reply all
Reply to author
Forward
0 new messages