[cgmanager-devel] [lxc/cgmanager] 34060d: fix: sysvinit invoke via path lookup, not /sbin

0 views
Skip to first unread message

GitHub

unread,
Feb 29, 2016, 8:23:55 PM2/29/16
to cgmanag...@lists.linuxcontainers.org
Branch: refs/heads/master
Home: https://github.com/lxc/cgmanager
Commit: 34060df2f7380fa1f4e957c0dab214fd73b3b2b5
https://github.com/lxc/cgmanager/commit/34060df2f7380fa1f4e957c0dab214fd73b3b2b5
Author: Scott Mcdermott <sc...@smemsh.net>
Date: 2016-01-30 (Sat, 30 Jan 2016)

Changed paths:
M config/init/sysvinit/cgmanager
M config/init/sysvinit/cgproxy

Log Message:
-----------
fix: sysvinit invoke via path lookup, not /sbin

The sysvinit scripts assume the install is in /sbin, and hardcode that
as the invocation path, even though the 'configure' script itself
defaults to /usr/local if no --prefix override is given (as standard for
autoconf).

This means an out-of-box compile will not even work with the provided
init scripts without modifying them by hand.

The locations used are:

- /usr/local/sbin/cgmanager: installation default
- /usr/bin/cgmanager: gentoo scripts assumption
- /sbin/cgmanager: debian packages give this prefix (and this is what
the script hardcodes)

Instead of harcoding one of the paths, have the init script look up the
invocation path at runtime to invoke cgmanager (although we still use a
hardcoded PATH, but include all three locations).


Commit: b7d7f136ff804a28cc22bdca3c0d9d39f7b32a89
https://github.com/lxc/cgmanager/commit/b7d7f136ff804a28cc22bdca3c0d9d39f7b32a89
Author: Scott Mcdermott <sc...@smemsh.net>
Date: 2016-01-30 (Sat, 30 Jan 2016)

Changed paths:
M config/init/sysvinit/cgmanager

Log Message:
-----------
fix: missed one hardcoded /sbin in sysvinit script

accidentally missed one full path specifier in previous commit, intended
to make all invocations occur via $PATH (there was an embedded call to
cgproxy in cgmanager's init script)


Commit: d4111652a5be3a4672ef32a1ac00d7655d2b0ca3
https://github.com/lxc/cgmanager/commit/d4111652a5be3a4672ef32a1ac00d7655d2b0ca3
Author: Serge Hallyn <se...@hallyn.com>
Date: 2016-02-29 (Mon, 29 Feb 2016)

Changed paths:
M config/init/sysvinit/cgmanager
M config/init/sysvinit/cgproxy

Log Message:
-----------
Merge pull request #24 from smemsh/invoke-via-path-lookup

sysvinit script hardcodes path to cgmanager as /sbin/cgmanager which breaks if elsewhere


Compare: https://github.com/lxc/cgmanager/compare/d4a1dc9ad438...d4111652a5be

Reply all
Reply to author
Forward
0 new messages