[cgmanager-devel] [lxc/cgmanager] 5a7d39: fix: force libnih to use /run for pidfile

0 views
Skip to first unread message

GitHub

unread,
Feb 4, 2016, 12:55:56 AM2/4/16
to cgmanag...@lists.linuxcontainers.org
Branch: refs/heads/master
Home: https://github.com/lxc/cgmanager
Commit: 5a7d39a43a98d83d6bd40077794074659b88c53c
https://github.com/lxc/cgmanager/commit/5a7d39a43a98d83d6bd40077794074659b88c53c
Author: Scott Mcdermott <sc...@smemsh.net>
Date: 2016-01-30 (Sat, 30 Jan 2016)

Changed paths:
M cgmanager-proxy.c
M cgmanager.c
M cgmanager.h

Log Message:
-----------
fix: force libnih to use /run for pidfile

After unshare() and pivot_root() during daemonization, we do not take
/var in with us (only /, /proc, and /run)

Since no /var exists after pivot, this means /var/run will not exist if
it's on a separate mount point from /. On contemporary systems for a
long while, /var/run is either a symlink or bind mount to /run anyways,
so we just tell libnih explicitly to use the pidfile in there rather
than using its default /var/run path (which won't work if /var is
separate anyways).

Patch originally submitted by rwor...@slackware.com, but they decided
to change libnih default to /run universally, so this patch wouldn't be
needed in that case (but wouldn't be a problem either).

Closes #22


Commit: 5729c00a5e273a7dbaf49d41bf58480f0f6f81ac
https://github.com/lxc/cgmanager/commit/5729c00a5e273a7dbaf49d41bf58480f0f6f81ac
Author: Serge Hallyn <se...@hallyn.com>
Date: 2016-02-03 (Wed, 03 Feb 2016)

Changed paths:
M cgmanager-proxy.c
M cgmanager.c
M cgmanager.h

Log Message:
-----------
Merge pull request #25 from smemsh/force-libnih-rundir

fix: force libnih to use /run for pidfile


Compare: https://github.com/lxc/cgmanager/compare/76c28a709c37...5729c00a5e27

Reply all
Reply to author
Forward
0 new messages