[mej/nhc] 5c1a44: nhc: Fix a typo in TS handling for modern bash

0 views
Skip to first unread message

Michael Jennings

unread,
Aug 29, 2023, 5:20:06 PM8/29/23
to nhc-...@lbl.gov
Branch: refs/heads/dev
Home: https://github.com/mej/nhc
Commit: 5c1a449ed29e8d92f103f2cdd3ac21eceecb0f1e
https://github.com/mej/nhc/commit/5c1a449ed29e8d92f103f2cdd3ac21eceecb0f1e
Author: Michael Jennings <m...@lanl.gov>
Date: 2023-08-29 (Tue, 29 Aug 2023)

Changed paths:
M nhc

Log Message:
-----------
nhc: Fix a typo in TS handling for modern bash

Apparently I can't read. Those are parentheses, not braces.


Commit: a583663112fcef9cbf2e1ea6fefc1752d1350cd8
https://github.com/mej/nhc/commit/a583663112fcef9cbf2e1ea6fefc1752d1350cd8
Author: Michael Jennings <m...@lanl.gov>
Date: 2023-08-29 (Tue, 29 Aug 2023)

Changed paths:
M configure.ac
M nhc

Log Message:
-----------
nhc: Keep commit hash out of Git's nhc

Somehow, somewhere along the line, the version of the `nhc` script in
the upstream source repositories (e.g., GitHub) got transformed to
include a Git commit hash and RPM release string in it. By design,
that change is an in-place alteration that should only ever impact the
`nhc` file that's being/been installed on a host.

Rather than fixing it manually, it occurred to me that automating and
enforcing that state would also help me to not forget to change the
`NHC_VERSION` line in `nhc` when I update the canonical version string
(as supplied to `AC_INIT()` in `configure.ac`).

So I added a quick stanza to `configure.ac` -- shockingly similar to
the one in `Makefile.am`, as it happens -- that will detect and
correct the aforementioned unfortunate situation if ever it should
recur!


Compare: https://github.com/mej/nhc/compare/c2c3efa9533c...a583663112fc
Reply all
Reply to author
Forward
0 new messages