[mej/nhc] a5a0cd: nhc: Use subshell syntax for offline/online ops

0 views
Skip to first unread message

Michael Jennings

unread,
Apr 10, 2023, 4:19:08 PM4/10/23
to nhc-...@lbl.gov
Branch: refs/heads/mej/fix/14-subshell-quote-args
Home: https://github.com/mej/nhc
Commit: a5a0cd75aae1f2e41fb3003b0d9876d0b5afaad3
https://github.com/mej/nhc/commit/a5a0cd75aae1f2e41fb3003b0d9876d0b5afaad3
Author: Michael Jennings <m...@lanl.gov>
Date: 2023-04-10 (Mon, 10 Apr 2023)

Changed paths:
M nhc

Log Message:
-----------
nhc: Use subshell syntax for offline/online ops

Using `eval` to invoke the node online and offline helper utilities
makes some assumptions about the content of each variable, and those
assumptions don't always match up with reality.

As suggested by @thedavidwhiteside in #14, using a subshell allows for
the same result but takes advantage of BASH-internal quoting
mechanisms that are content-driven. No assumptions needed.

For consistency, I updated both the "online" and "offline"
invocations.

Fixes #14.


Michael Jennings

unread,
Apr 10, 2023, 4:48:08 PM4/10/23
to nhc-...@lbl.gov
Branch: refs/heads/dev
Commit: 784a62aee27fc1a53190b29a9cfd6dc083b1fe50
https://github.com/mej/nhc/commit/784a62aee27fc1a53190b29a9cfd6dc083b1fe50
Author: Michael Jennings <m...@lanl.gov>
Date: 2023-04-10 (Mon, 10 Apr 2023)

Changed paths:
M nhc

Log Message:
-----------
Merge pull request #131 from mej/mej/fix/14-subshell-quote-args

nhc: Use subshell syntax for offline/online ops


Compare: https://github.com/mej/nhc/compare/7e2a8c6a94c0...784a62aee27f
Reply all
Reply to author
Forward
0 new messages