You received this message because you are subscribed to the Google Groups "dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@kubernetes.io.
To view this discussion on the web visit https://groups.google.com/a/kubernetes.io/d/msgid/dev/yrjh7cvr8cje.fsf%40pohly-mobl1.fritz.box.
To view this discussion on the web visit https://groups.google.com/a/kubernetes.io/d/msgid/dev/CABhP%3DtbE7ccvhCXYdy8Z2MuwjrtS-7fJgRK-k%2BoyHbLg8H2qRQ%40mail.gmail.com.
Patrick, thank you thank you thank you! I’m definitely a fan of consistent (even strict) application of norms in a project because of how it contributes to both long term maintainability and makes new contributors’ experiences easier because there’s less guesswork.
With a short look in one area, I like most of the proposed fixes I was given. I’ll say “gocritic” stands out as opinionated in a few places I maybe disagree with for long term maintainability of code. What are other seeing? Any concerns about any of sub-linters?
Principal Engineer, Open Source Program Office
Davanum Srinivas <dav...@gmail.com>
Date: Wednesday, March 8, 2023 at 8:03 AM
To: antonio.o...@gmail.com <antonio.o...@gmail.com>
Cc: patric...@intel.com <patric...@intel.com>, d...@kubernetes.io <d...@kubernetes.io>
Subject: Re: raising the quality bar: additional linter checks for new code
Indeed, thanks Patrick! We can do an umbrella issue to coordinate the PR(s) and ensure we do meaningful work when 1.28 opens up!
On Wed, Mar 8, 2023 at 10:56 AM Antonio Ojea <antonio.o...@gmail.com> wrote:
This is a great addition Patrick, thanks for working on this
"Patrick Ohly" <patric...@intel.com> writes:
> I would like propose that we reconsider how we increase code quality in
> Kubernetes. [...] My proposal is that we enable linter checks for
> known issues *before* all old code has been updated.