cloud-controller-manager by default on CI for jobs using cluster/kube-up.sh

43 views
Skip to first unread message

Davanum Srinivas

unread,
Sep 2, 2023, 1:38:35 PM9/2/23
to d...@kubernetes.io
Folks,

On behalf of sig-cloud-provider ... Heads up, we landed https://github.com/kubernetes/kubernetes/pull/120263 a few days ago where we are switching the `--cloud-provider=gce` to `--cloud-provider=external` essentially as the default. Jobs that explicitly set the CLOUD_PROVIDER and corresponding feature flags DisableCloudProviders + DisableKubeletCloudCredentialProviders should work fine as such.


If you notice your periodic job or presubmit fail, you have two choices :)

Choice #1: quickly fix the job(s) to work with the external cloud provider as that will be the default as we go forward
Choice #2: Set the CI job to explicitly use the `CLOUD_PROVIDER=gce` and set both DisableCloudProviders and DisableCloudProviders to false (see examples in the query above)

We have PR(s) in progress that will explicitly warn in your build/api-server logs etc, but hop on to #sig-testing and we can chat about options. Note that Choice #2 is temporary as we will need to remove the in-tree cloud providers anyway soon enough!

The release blocking jobs have been fixed mostly now ( https://github.com/kubernetes/kubernetes/issues/120367 ) except for the kubetest2 job where a PR is in progress.

Thanks,
Dims

--
Davanum Srinivas :: https://twitter.com/dims

Davanum Srinivas

unread,
Sep 3, 2023, 3:27:56 PM9/3/23
to d...@kubernetes.io
Folks,

Antonio tracked down and fixed the issue in:

TL;DR - CloudAllocator ipam controller from KCM gets tripped up with the "external" cloud provider and hence needs to be disabled.

If you see any other issues, please open and issue and poke us on slack.

thanks,
Dims

Madhav Jivrajani

unread,
Sep 3, 2023, 10:45:47 PM9/3/23
to dav...@gmail.com, d...@kubernetes.io
Thank you Antonio and Dims!

— Madhav 

On Mon, 4 Sep 2023 at 12:57 AM, Davanum Srinivas <dav...@gmail.com> wrote:
Folks,

Antonio tracked down and fixed the issue in:

TL;DR - CloudAllocator ipam controller from KCM gets tripped up with the "external" cloud provider and hence needs to be disabled.

If you see any other issues, please open and issue and poke us on slack.

thanks,
Dims

On Sat, Sep 2, 2023 at 1:38 PM Davanum Srinivas <dav...@gmail.com> wrote:
Folks,

On behalf of sig-cloud-provider ... Heads up, we landed https://github.com/kubernetes/kubernetes/pull/120263 a few days ago where we are switching the `--cloud-provider=gce` to `--cloud-provider=external` essentially as the default. Jobs that explicitly set the CLOUD_PROVIDER and corresponding feature flags DisableCloudProviders + DisableKubeletCloudCredentialProviders should work fine as such.


If you notice your periodic job or presubmit fail, you have two choices :)

Choice #1: quickly fix the job(s) to work with the external cloud provider as that will be the default as we go forward
Choice #2: Set the CI job to explicitly use the `CLOUD_PROVIDER=gce` and set both DisableCloudProviders and DisableCloudProviders to false (see examples in the query above)

We have PR(s) in progress that will explicitly warn in your build/api-server logs etc, but hop on to #sig-testing and we can chat about options. Note that Choice #2 is temporary as we will need to remove the in-tree cloud providers anyway soon enough!

The release blocking jobs have been fixed mostly now ( https://github.com/kubernetes/kubernetes/issues/120367 ) except for the kubetest2 job where a PR is in progress.

Thanks,
Dims

--
Davanum Srinivas :: https://twitter.com/dims


--
Davanum Srinivas :: https://twitter.com/dims

--
You received this message because you are subscribed to the Google Groups "dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dev+uns...@kubernetes.io.
To view this discussion on the web visit https://groups.google.com/a/kubernetes.io/d/msgid/dev/CANw6fcECEy5rkRvS3hidMvCr_OnQLrABvAUbU7dLUAt_yjUv1g%40mail.gmail.com.

Wojciech Tyczyński

unread,
Sep 4, 2023, 6:00:14 AM9/4/23
to dav...@gmail.com, d...@kubernetes.io
 Thanks for quickly fixing this Antonio - having tests to run the desired setup helps us hugely with validating the setup!

On Sun, Sep 3, 2023 at 9:27 PM Davanum Srinivas <dav...@gmail.com> wrote:
Folks,

Antonio tracked down and fixed the issue in:

TL;DR - CloudAllocator ipam controller from KCM gets tripped up with the "external" cloud provider and hence needs to be disabled.

If you see any other issues, please open and issue and poke us on slack.

thanks,
Dims

On Sat, Sep 2, 2023 at 1:38 PM Davanum Srinivas <dav...@gmail.com> wrote:
Folks,

On behalf of sig-cloud-provider ... Heads up, we landed https://github.com/kubernetes/kubernetes/pull/120263 a few days ago where we are switching the `--cloud-provider=gce` to `--cloud-provider=external` essentially as the default. Jobs that explicitly set the CLOUD_PROVIDER and corresponding feature flags DisableCloudProviders + DisableKubeletCloudCredentialProviders should work fine as such.


If you notice your periodic job or presubmit fail, you have two choices :)

Choice #1: quickly fix the job(s) to work with the external cloud provider as that will be the default as we go forward
Choice #2: Set the CI job to explicitly use the `CLOUD_PROVIDER=gce` and set both DisableCloudProviders and DisableCloudProviders to false (see examples in the query above)

We have PR(s) in progress that will explicitly warn in your build/api-server logs etc, but hop on to #sig-testing and we can chat about options. Note that Choice #2 is temporary as we will need to remove the in-tree cloud providers anyway soon enough!

The release blocking jobs have been fixed mostly now ( https://github.com/kubernetes/kubernetes/issues/120367 ) except for the kubetest2 job where a PR is in progress.

Thanks,
Dims

--
Davanum Srinivas :: https://twitter.com/dims


--
Davanum Srinivas :: https://twitter.com/dims

--

Davanum Srinivas

unread,
Sep 4, 2023, 7:29:32 AM9/4/23
to Wojciech Tyczyński, d...@kubernetes.io
Reply all
Reply to author
Forward
0 new messages