CGB billing period validation on FY

1 view
Skip to first unread message

Tammy-Lu Vandevender

unread,
May 8, 2018, 4:31:50 PM5/8/18
to kfs.us...@kuali.org
All,
While testing the CG Invoices (CINV) during our fiscal year end testing, we found that KFS has an edit that requires the Last Billed Date's FY to match the current date's FY.  Why is this edit in the code?  This will not work for invoices that cross over to the new FY.  Grants do not operate on FY time periods.  In our case, we are trying to generate 'June' invoices in 'July' where June is in the prior FY (2018) and July is in the new FY (2019).  KFS returns an error ' Award is not eligible to be invoiced in the current billing period. '

This edit was not in the pre-release version of CGB that we were running.  This is the code in our KFS6 version:
 protected boolean canThisBeBilledByBillingFrequency() {
        if (StringUtils.equals(billingFrequency, ArConstants.ANNUALLY_BILLING_SCHEDULE_CODE) && accountingPeriodService.getByDate(lastBilledDate).getUniversityFiscalYear() >= accountingPeriodService.getByDate(currentDate).getUniversityFiscalYear()) {
            return false;
        } else if (StringUtils.equals(findPreviousAccountingPeriod(currentDate).getUniversityFiscalPeriodCode(), findPreviousAccountingPeriod(lastBilledDate).getUniversityFiscalPeriodCode()) &&
                accountingPeriodService.getByDate(lastBilledDate).getUniversityFiscalYear().equals(accountingPeriodService.getByDate(currentDate).getUniversityFiscalYear())) {
                return false;
        }

        return true;
    }

We believe this is a bug and plan to remove the FY check.  But I would like to understand why the edit is the code.

Thanks in advance.
tammy


--

Tammy Vandevender | Director | University of Hawaii System  |  Financial Management Office - Fiscal Services Office
1406 Lower Campus Road, Room 43 | Honolulu, HI  96822
phone: 808-956-0383 |  ta...@hawaii.edu

Kymber Taylor

unread,
May 8, 2018, 5:03:20 PM5/8/18
to Tammy-Lu Vandevender, kfs.us...@kuali.org
Hi Tammy, I found this JIRA where it looks like Period 01 is supposed to look at the prior FY and periods 02-12 should look at the current FY. The fact that it's not is indeed a bug. Per this JIRA the code is supposed to look at the prior FY when calcing period 01.  It seems like the FY check isn't needed if the code is looking at current and prior FY to determine what should be invoiced? 


Thanks, Kymber




--
You received this message because you are subscribed to the Google Groups "Kuali Financials Functional User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kfs.user.func+unsubscribe@kuali.org.



--
Kuali logo
Kymber Taylor 
Financials Business Analyst
520-404-6442
kuali.co
Best place to work 2016

Tammy-Lu Vandevender

unread,
May 8, 2018, 5:20:17 PM5/8/18
to Kymber Taylor, kfs.us...@kuali.org
Kymber,
Yes, I don't think the FY check is needed.  Not sure why it was in there in the first place.  Because of that, the code doesn't even get to this balance calculation where it looks at the prior year balances.  We will proceed with removing that validation.

thanks,
tammy
Reply all
Reply to author
Forward
0 new messages