Failing spice integration test

[Andras Tantos]

Hello!

I'm trying to submit a pull request, but there are some failing merge
tests so the request is blocked. The test in question all boil down to
the following error:

> /builds/andras_tantos/kicad/qa/tests/spice/test_library_spice.cpp(148):
> error: in "SimLibrarySpice/Bjts": check param->value == fmt::format(
> "{}000.0{}M", i % 10, i % 10 ) has failed [100.001E+07 != 1000.01M]
> Failure occurred in a following context:
>     Model index: 1, Model name: _1_PNP_VBIC, Model device type: PNP,
> Model type: VBIC
>     Param name: ver

I don't believe this failure has anything to do with my change plus the
values are actually numerically the same, only the representation is
different. Is it a known issue? If so, how can I unblock myself? If not,
is the expected behavior the correct one?

Thanks,
Andras

[Jeff Young]

It’s known to be acting up, but we don’t know why yet (it seems to only occur on some machines).

Note that devs can push your MR even if it’s failing tests, so it’s not a huge issue.

Cheers,
Jeff.

> --
> You received this message because you are subscribed to the Google Groups "KiCad Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to devlist+u...@kicad.org.
> To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/21622c86-44d4-48c7-ae2a-29fd4c5babaa%40tantosonline.com.

[Andras Tantos]

Thanks! However it seems that the merge is blocked with the failing tests. How can I get the request through even with the failures in place? (Apologies, I'm new to this process, need some education.)

Thanks,
Andras

>> https://groups.google.com/a/kicad.org/d/msgid/devlist/21622c86-44d4-48c7-ae2a-29fd4c5babaa@tantosonl
>> ne.com.

>
> --
> You received this message because you are subscribed to the Google Groups "KiCad Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
> devlist+u...@kicad.org.
> To view this discussion on the web visit

> https://groups.google.com/a/kicad.org/d/msgid/devlist/F2F231FF-893B-40D3...@rokeby.ie

[Seth Hillbrand]

I wouldn't worry about the pipeline failing.  Once we discuss the change and decide to merge it, it is not an issue.

Seth Hillbrand

Lead Developer

+1-530-302-5483‬

Long Beach, CA

www.kipro-pcb.com    in...@kipro-pcb.com

To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/d4bdc22ac2c21f8a716fbe1428c5a8b8%40tantosonline.com.

[Andras Tantos]

I'm sorry for being so obtuse, but in that case how do I submit the merge request to kick off the discussion?

Thanks,
Andras

To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/CAFdeG-q87GLO-Ug2-mj3dcmGKojZzNXpDv_mn1fEUHiBSQH%3DXQ%40mail.gmail.com.

[Jon Evans]

It looks like you have already done so successfully at https://gitlab.com/kicad/code/kicad/-/merge_requests/1992

Pipeline status has nothing to do with whether or not a merge request can be reviewed or discussed. 

To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/0990aed1-2ca0-4f9d-82e5-7fe3cc844ee0%40tantosonline.com.

[Jeff Young]

FWIW, the failing SPICE tests *should* (TM) be fixed now.

To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/CA%2BqGbCDQw0Y_kQRtvis72T28i6_9DNEk4K4%2ByzEmRHjaQDwBFQ%40mail.gmail.com.

[Andras Tantos]

Oh cool, I didn't know that. Thanks a bunch!

Andras

To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/CA%2BqGbCDQw0Y_kQRtvis72T28i6_9DNEk4K4%2ByzEmRHjaQDwBFQ%40mail.gmail.com.