Update on merge request to support HiSilicon's Kunpeng 920

26 views
Skip to first unread message

Lau Mercadal Melià

unread,
Aug 31, 2021, 3:48:15 AM8/31/21
to perfmon...@lists.sourceforge.net, ptools-...@icl.utk.edu, era...@googlemail.com
Good morning,

Some months ago (April 1st) we opened a merge request to add support
for ARM v8.2 HiSilicon's Kunpeng 920 core and uncore PMU events
(https://sourceforge.net/p/perfmon2/libpfm4/merge-requests/17/).

As of today we still have not received any update on its status.

Is there a way to know if it's being considered? if we missed
something? if it needs further work? Are merge requests the way to
submit patches to libpfm4? Is there an alternative method?

How could we get some insight?

Kind regards,
-- Lau
signature.asc

Stephane Eranian

unread,
Aug 31, 2021, 3:51:09 PM8/31/21
to Lau Mercadal Melià, ptools-perfapi
Hi,

Sorry for the long delay. I missed that merge. Usually people send me
the patches directly.
I looked at the patches. They look good. However I prefer is core and
uncore patches are
separated. This makes each patch smaller and easier to review and
separate features more
easily.
Do you mind splitting the first patch into two parrts?
Please send them to me directly.
Thanks.

Lau Mercadal Melià

unread,
Sep 1, 2021, 3:12:22 AM9/1/21
to era...@gmail.com, ptools-perfapi
Hi,

Not a problem, it's good to know there's a more direct way to
contribute to libpfm4.

Thanks for taking the time to look at the patch, I'll split it right
away into core and uncore changes and send them directly to you.

Regards,
-- Lau

On Tue, 2021-08-31 at 12:50 -0700, 'Stephane Eranian' via ptools-
signature.asc

Stephane Eranian

unread,
Sep 3, 2021, 3:31:06 PM9/3/21
to Lau Mercadal Melià, ptools-perfapi
On Wed, Sep 1, 2021 at 12:12 AM Lau Mercadal Melià <lau.me...@bsc.es> wrote:
>
> Hi,
>
> Not a problem, it's good to know there's a more direct way to
> contribute to libpfm4.
>
> Thanks for taking the time to look at the patch, I'll split it right
> away into core and uncore changes and send them directly to you.
>
Thanks.
Reply all
Reply to author
Forward
0 new messages