Jeff Johnston
unread,Jul 31, 2017, 1:34:40 PM7/31/17Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Kito Cheng, Newlib, Palmer Dabbelt, Andrew Waterman, pat...@groups.riscv.org
Hi Kito,
Before I continue reviewing, I have noticed that you have no licensing
information in any of your non-generated files. You need to add this
as Red Hat has
the default license. You can make it BSD-like or see other licenses
in the repository that are even more permissive. That said, you have
another issue in that one of your files (asm.h) in the first patch has
been taken from glibc and is LPGL. This can cause problems unless you
are building newlib as a dynamic library as code that links to your
library becomes LGPL unless it provides everything required to relink.
See:
https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking
My suggestion would be to create your own version of asm.h and any
other files that are LGPL and license them how you see fit.
Regards,
-- Jeff J.