Jan 14, 2019, 9:00:38 PM1/14/19
Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message as abuse
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Kito Cheng, Binutils, Palmer Dabbelt, RISC-V Patches
On Wed, Jan 9, 2019 at 12:28 PM Jim Wilson <ji...@sifive.com
> On Wed, Jan 9, 2019 at 5:47 AM Kito Cheng <kito....@gmail.com
> > This is version 2 patch of implement the RISC-V ELF attribute merge.
This looks good. It fixes the testsuite failures I had with only the
other two patches applied.
I noticed one place in riscv_merge_non_std_and_sv_ext where you still
have a line that ends with an open paren, but that is a minor style
I found it interesting that now that we use standard numbering for
attributes and standard code for parsing them, we can't have a zero
value Tag_RISCV_unaligned_access attribute anymore, as the standard
code filters out attributes with default values. That looks OK
though, I don't think it will be a problem.
This is OK to go in once the other two patches are in.