[PATCH] RISC-V: Reject empty rouding mode and fence operand.

[Kito Cheng]

Hi Jim:

Current assembler will accept empty operand for fence and rounding
mode, such as "fence ," or "fadd.s fa1,fa1,fa1,", it cause by strncmp
with zero length in arg_lookup function.

This patch including the fix and add 2 test cases for that, those case
was explored by LLVM's MC fuzzer testing tool developed by Ana's team
(Codeaurora) :)


gas/ChangeLog

2018-08-21 Kito Cheng <ki...@andestech.com>

* config/tc-riscv.c (arg_lookup): Checking
lenght before look up.
* testsuite/gas/riscv/fence-fail.d: New file.
* testsuite/gas/riscv/fence-fail.l: Likewise.
* testsuite/gas/riscv/fence-fail.s: Likewise.
* testsuite/gas/riscv/rouding-fail.d: Likewise.
* testsuite/gas/riscv/rouding-fail.l: Likewise.
* testsuite/gas/riscv/rouding-fail.s: Likewise.

[Jim Wilson]

On Tue, Aug 21, 2018 at 8:53 AM, Kito Cheng <kito....@gmail.com> wrote:
> Current assembler will accept empty operand for fence and rounding
> mode, such as "fence ," or "fadd.s fa1,fa1,fa1,", it cause by strncmp
> with zero length in arg_lookup function.

There is a ChangeLog entry but no patch.

There is a typo in the ChangeLog entry
lenght -> length

Jim

[Kito Cheng]

Hi Jim:

Oh, my mistake..., patch attached.

gas/ChangeLog

2018-08-21 Kito Cheng <ki...@andestech.com>

* config/tc-riscv.c (arg_lookup): Checking

length before look up.

* testsuite/gas/riscv/fence-fail.d: New file.
* testsuite/gas/riscv/fence-fail.l: Likewise.
* testsuite/gas/riscv/fence-fail.s: Likewise.
* testsuite/gas/riscv/rouding-fail.d: Likewise.
* testsuite/gas/riscv/rouding-fail.l: Likewise.
* testsuite/gas/riscv/rouding-fail.s: Likewise.

> --
> You received this message because you are subscribed to the Google Groups "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to patches+u...@groups.riscv.org.
> To post to this group, send email to pat...@groups.riscv.org.
> Visit this group at https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit https://groups.google.com/a/groups.riscv.org/d/msgid/patches/CAFyWVabKZpw6g4P8Dq_1MMKCLv1yemTsNH6hQ%3DFbKndKL0omkg%40mail.gmail.com.
> For more options, visit https://groups.google.com/a/groups.riscv.org/d/optout.

[Jim Wilson]

On 08/21/2018 06:29 PM, Kito Cheng wrote:
>> On Tue, Aug 21, 2018 at 8:53 AM, Kito Cheng <kito....@gmail.com> wrote:
>>> Current assembler will accept empty operand for fence and rounding
>>> mode, such as "fence ," or "fadd.s fa1,fa1,fa1,", it cause by strncmp
>>> with zero length in arg_lookup function.

Thanks. I did some cross rv{32,64}-{elf,linux} testing and then
committed your patch.

Jim