Newlib/libgloss port for RISC-V
121 views
Skip to first unread message
Kito Cheng
Jul 27, 2017, 4:35:40 AM7/27/17
to new...@sourceware.org, Palmer Dabbelt, Andrew Waterman, pat...@groups.riscv.org
Hi all:
We'd like to contribute for RISC-V[1] support to newlib/libgloss.
RISC-V is an open ISA which support both 32 and 64 bit.
For the other part of GNU toolchain, GCC and binutils already included
in upstream in GCC 7 / binutils 2.28.
We've also tested with newlib and gcc testsuite for following targets:
riscv32-unknown-elf
riscv64-unknown-elf
Contributor list:
- Andrew Waterman <and...@sifive.com>
- Kito Cheng <kito....@gmail.com>
- Palmer Dabbelt <pal...@dabbelt.com>
- Scott Beamer <sbe...@eecs.berkeley.edu>
- Michael Neilly <mne...@yahoo.com>
- Alex Suykov <alex....@gmail.com>
[1] https://riscv.org/
We'd like to contribute for RISC-V[1] support to newlib/libgloss.
RISC-V is an open ISA which support both 32 and 64 bit.
For the other part of GNU toolchain, GCC and binutils already included
in upstream in GCC 7 / binutils 2.28.
We've also tested with newlib and gcc testsuite for following targets:
riscv32-unknown-elf
riscv64-unknown-elf
Contributor list:
- Andrew Waterman <and...@sifive.com>
- Kito Cheng <kito....@gmail.com>
- Palmer Dabbelt <pal...@dabbelt.com>
- Scott Beamer <sbe...@eecs.berkeley.edu>
- Michael Neilly <mne...@yahoo.com>
- Alex Suykov <alex....@gmail.com>
[1] https://riscv.org/
Kito Cheng
Jul 27, 2017, 4:52:13 AM7/27/17
to Palmer Dabbelt, Andrew Waterman, pat...@groups.riscv.org
Oop, this mail was rejected by mailer-daemon due to large than 100k...
Kito Cheng
Jul 27, 2017, 5:29:28 AM7/27/17
to new...@sourceware.org, Palmer Dabbelt, Andrew Waterman, pat...@groups.riscv.org
Hi all:
We'd like to contribute for RISC-V[1] support to newlib/libgloss.
RISC-V is an open ISA which support both 32 and 64 bit.
For the other part of GNU toolchain, GCC and binutils already included
in upstream in GCC 7 / binutils 2.28.
We've also tested with newlib and gcc testsuite for following targets:
riscv32-unknown-elf
riscv64-unknown-elf
[PATCH 1/3] Add RISC-V port for newlib
We'd like to contribute for RISC-V[1] support to newlib/libgloss.
RISC-V is an open ISA which support both 32 and 64 bit.
For the other part of GNU toolchain, GCC and binutils already included
in upstream in GCC 7 / binutils 2.28.
We've also tested with newlib and gcc testsuite for following targets:
riscv32-unknown-elf
riscv64-unknown-elf
https://sourceware.org/ml/newlib/2017/msg00669.html
[PATCH 2/3] Add RISC-V port for libm
https://sourceware.org/ml/newlib/2017/msg00670.html
[PATCH 3/3] Add RISC-V port for libgloss
https://sourceware.org/ml/newlib/2017/msg00671.html
Jeff Johnston
Jul 31, 2017, 1:34:40 PM7/31/17
to Kito Cheng, Newlib, Palmer Dabbelt, Andrew Waterman, pat...@groups.riscv.org
Hi Kito,
Before I continue reviewing, I have noticed that you have no licensing
information in any of your non-generated files. You need to add this
as Red Hat has
the default license. You can make it BSD-like or see other licenses
in the repository that are even more permissive. That said, you have
another issue in that one of your files (asm.h) in the first patch has
been taken from glibc and is LPGL. This can cause problems unless you
are building newlib as a dynamic library as code that links to your
library becomes LGPL unless it provides everything required to relink.
See: https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking
My suggestion would be to create your own version of asm.h and any
other files that are LGPL and license them how you see fit.
Regards,
-- Jeff J.
Before I continue reviewing, I have noticed that you have no licensing
information in any of your non-generated files. You need to add this
as Red Hat has
the default license. You can make it BSD-like or see other licenses
in the repository that are even more permissive. That said, you have
another issue in that one of your files (asm.h) in the first patch has
been taken from glibc and is LPGL. This can cause problems unless you
are building newlib as a dynamic library as code that links to your
library becomes LGPL unless it provides everything required to relink.
See: https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking
My suggestion would be to create your own version of asm.h and any
other files that are LGPL and license them how you see fit.
Regards,
-- Jeff J.
Kito Cheng
Jul 31, 2017, 10:36:41 PM7/31/17
to pat...@groups.riscv.org, Newlib, Palmer Dabbelt, Andrew Waterman
Hi Jeff:
Thanks for your review, we'll review and add the licensing
information for every file again and update the patch set.
> --
> You received this message because you are subscribed to the Google Groups "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to patches+u...@groups.riscv.org.
> To post to this group, send email to pat...@groups.riscv.org.
> Visit this group at https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit https://groups.google.com/a/groups.riscv.org/d/msgid/patches/CAOox84vm6%2BnCNSa1aDROUJgXJMentreipYYfyTk%2BuBk2X-t4Lw%40mail.gmail.com.
> For more options, visit https://groups.google.com/a/groups.riscv.org/d/optout.
Thanks for your review, we'll review and add the licensing
information for every file again and update the patch set.
> You received this message because you are subscribed to the Google Groups "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to patches+u...@groups.riscv.org.
> To post to this group, send email to pat...@groups.riscv.org.
> Visit this group at https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit https://groups.google.com/a/groups.riscv.org/d/msgid/patches/CAOox84vm6%2BnCNSa1aDROUJgXJMentreipYYfyTk%2BuBk2X-t4Lw%40mail.gmail.com.
> For more options, visit https://groups.google.com/a/groups.riscv.org/d/optout.
Reply all
Reply to author
Forward
0 new messages