Encapsulating public field in KeyboardEvent (Y/N))?

Skip to first unread message

Filip Filmar

Nov 16, 2021, 11:01:55 AM11/16/21
to ui-inp...@fuchsia.dev
Hi folks!

As I am adding quite a few optional fields to KeyboardEvent, it is becoming a bit unwieldy to keep
fixing direct instantiations across the code base.

Perhaps it is as good a time as any to make all the fields on `KeyboardEvent` private, and allow access to the internal state via accessor methods.  This shouldn't make access any more difficult, but will make evolving KeyboardEvent easier.



Konstantin Pozin

Nov 16, 2021, 12:28:06 PM11/16/21
to Filip Filmar, ui-inp...@fuchsia.dev
Sounds good to me.


All posts must follow the Fuchsia Code of Conduct https://fuchsia.dev/fuchsia-src/CODE_OF_CONDUCT or may be removed.
You received this message because you are subscribed to the Google Groups "ui-input-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ui-input-dev...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/ui-input-dev/CAGEh6bhM0_64qZK4%3DEMU9WjQ4k8JZe4eHZFSmnsb-QbAJe0ydA%40mail.gmail.com.

Mukesh Agrawal

Nov 16, 2021, 2:21:07 PM11/16/21
to Konstantin Pozin, Filip Filmar, ui-inp...@fuchsia.dev
Yeah, sounds reasonable --- as we're doing more with it, there are probably invariants we want an event to upload, instead of just being a bundle of bits.

Reply all
Reply to author
0 new messages