How to add UFS device information to pci.ids?

[Jaeyoon Choi]

Hi, 

I have questions about pci.ids, which is the third_party code.

I am currently implementing a UFS Driver.
To test the UFS driver, I bind a UFS device to Fuchsia and checked the information with 'lspci' and found that it says "Mass storage controller".
The reason is that there is no UFS information in //third_party/pciids/pci.ids, so it does not know the UFS sub-class name.

Therefore, if I add the UFS sub-class information to the pci.ids file as shown below, I can see the UFS device with lspci.

```
diff --git a/pci.ids b/pci.ids
index 186f475..da9d2ed 100644
--- a/pci.ids
+++ b/pci.ids
@@ -32862,6 +32862,9 @@ C 01  Mass storage controller
        08  Non-Volatile memory controller
                01  NVMHCI
                02  NVM Express
+       09  Universal Flash Storage controller
+               00  Vendor specific
+               01  UFSHCI
        80  Mass storage controller
 C 02  Network controller
        00  Ethernet controller
```

To add UFS sub-class information to pci.ids, I am going to contribute to pci.ids according to the guide in https://pci-ids.ucw.cz/.

My question is, how do I apply pci.ids with UFS device information to fuchsia's third_party?
For reference, if you check the logs in //third_party/pciids, you can see that it was last synced in 2020.

 

Thanks,

 

Jaeyoon Choi 

 

[Suraj Malhotra]

+Christopher Anderson 

--
All posts must follow the Fuchsia Code of Conduct https://fuchsia.dev/fuchsia-src/CODE_OF_CONDUCT or may be removed.
---
You received this message because you are subscribed to the Google Groups "storage-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to storage-dev...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/storage-dev/20230331063410epcms2p4e295cf089ed222c3a5fbb5c03487d536%40epcms2p4.

[Christopher Anderson]

I can update our ID database to be more current, but generally would prefer to leave modifications out of the repo. You don't have the numbers in the screenshots so I can't tell: are these IDs upstream already?

[최재윤]

I haven't upstreamed the UFS IDs yet, I'll let you know when I do and it's merged into the database.

Thanks.

 

 

--------- Original Message ---------

Sender : Christopher Anderson <c...@google.com>

Date : 2023-04-01 02:26 (GMT+9)

Title : Re: How to add UFS device information to pci.ids?

--

All posts must follow the Fuchsia Code of Conduct https://fuchsia.dev/fuchsia-src/CODE_OF_CONDUCT or may be removed. --- You received this message because you are subscribed to the Google Groups "storage-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to storage-dev...@fuchsia.dev. To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/storage-dev/20230331063410epcms2p4e295cf089ed222c3a5fbb5c03487d536%40epcms2p4.

 

[Christopher Anderson]

Sounds good, I'll update our pci id database once it's upstream. Thanks for bringing it to my attention.

[최재윤]

The UFS sub-class merged into pciids. Please update Fuchsia's database. Thanks!

https://pci-ids.ucw.cz/read/PD/01/09

 

 

--------- Original Message ---------

Sender : Christopher Anderson <c...@google.com>

Date : 2023-04-04 02:26 (GMT+9)

Title : Re: (2) How to add UFS device information to pci.ids?

[Christopher Anderson]

Thanks for the update, I've filed https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=125271 and will get to it in the near future.