[L] Change in fuchsia/fuchsia[main]: Revert "[versioning] Update schema of version_history.json"

1 view
Skip to first unread message

Rasha Eqbal (Gerrit)

unread,
Apr 18, 2023, 2:40:25 PM4/18/23
to Sébastien Marchand, Danielle Kay, Aaron Wood, CQ Bot, Dave Schuyler, Marc-Antoine Ruel, Kendal Harland, Seth Ladd, David Turner, GI Roller

Attention is currently required from: Aaron Wood, Danielle Kay, Dave Schuyler, Kendal Harland, Marc-Antoine Ruel, Sébastien Marchand.

Rasha Eqbal would like Sébastien Marchand, Danielle Kay, Aaron Wood, CQ Bot, Dave Schuyler, Marc-Antoine Ruel and Kendal Harland to review this change.

View Change

Revert "[versioning] Update schema of version_history.json"

This reverts commit 47f758b8245433c1fcce9ec7514642d52bce6132.

Reason for revert: flakes in go/version-history-test.sh

Original change's description:
> [versioning] Update schema of version_history.json
>
> Initial step in a larger effort to refactor version configs in the codebase. Transitioned from array of dicts to a dict, to better support status and multiple ABI revisions per API level in the future.
>
> Bug: 105614
> Multiply: fuchsia-pkg://fuchsia.com/stardroid_tests#meta/sh_test.cm: 10
> Change-Id: I8efcd57926ddd64d9658147f63e909e9fcfba821
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/834238
> Commit-Queue: Danielle Kay <dan...@google.com>
> Reviewed-by: Marc-Antoine Ruel <mar...@google.com>
> Reviewed-by: Kendal Harland <kjha...@google.com>
> Reviewed-by: Sébastien Marchand <sebma...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>
> Reviewed-by: Dave Schuyler <dsch...@google.com>

Bug: 105614
Change-Id: Ib2a082315ee5f32b1c782708412b75039b0aeeed
---
M build/bazel_sdk/bazel_rules_fuchsia/fuchsia/workspace/sdk_templates/generate_sdk_build_rules.bzl
M build/bazel_sdk/tests/sdk_generation/goldens/simple_idk_arm64/version_history.json
M build/bazel_sdk/tests/sdk_generation/goldens/simple_idk_both/version_history.json
M build/bazel_sdk/tests/sdk_generation/goldens/simple_idk_x64/version_history.json
M build/sdk/meta/BUILD.gn
D build/sdk/meta/golden/version_history-3349aec7.json.golden
D build/sdk/meta/version_history-3349aec7.json
M scripts/sdk/gn/test_project/.gn
M scripts/versioning/update_platform_version.py
M scripts/versioning/update_platform_version_tests.py
M sdk/BUILD.gn
M sdk/manifests/layouts/arm64/sdk_directory_core.golden_layout
M sdk/manifests/layouts/arm64/sdk_directory_core_testing.golden_layout
M sdk/manifests/layouts/arm64/sdk_directory_e2e_testing.golden_layout
M sdk/manifests/layouts/arm64/sdk_directory_modular_testing.golden_layout
M sdk/manifests/layouts/x64/sdk_directory_core.golden_layout
M sdk/manifests/layouts/x64/sdk_directory_core_testing.golden_layout
M sdk/manifests/layouts/x64/sdk_directory_e2e_testing.golden_layout
M sdk/manifests/layouts/x64/sdk_directory_modular_testing.golden_layout
M sdk/version_history.json
M src/lib/versioning/version-history/go/version_history.go
M src/lib/versioning/version-history/go/version_history.json
M src/lib/versioning/version-history/go/version_history_test.go
M src/lib/versioning/version-history/rust/proc-macro/shared/src/lib.rs
M src/sys/base-resolver/src/component.rs
25 files changed, 275 insertions(+), 352 deletions(-)


To view, visit change 839176. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib2a082315ee5f32b1c782708412b75039b0aeeed
Gerrit-Change-Number: 839176
Gerrit-PatchSet: 1
Gerrit-Owner: Rasha Eqbal <rasha...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Danielle Kay <dan...@google.com>
Gerrit-Reviewer: Dave Schuyler <dsch...@google.com>
Gerrit-Reviewer: Kendal Harland <kjha...@google.com>
Gerrit-Reviewer: Marc-Antoine Ruel <mar...@google.com>
Gerrit-Reviewer: Sébastien Marchand <sebma...@google.com>
Gerrit-CC: David Turner <di...@google.com>
Gerrit-CC: Seth Ladd <seth...@google.com>
Gerrit-Attention: Sébastien Marchand <sebma...@google.com>
Gerrit-Attention: Aaron Wood <aaro...@google.com>
Gerrit-Attention: Danielle Kay <dan...@google.com>
Gerrit-Attention: Dave Schuyler <dsch...@google.com>
Gerrit-Attention: Marc-Antoine Ruel <mar...@google.com>
Gerrit-Attention: Kendal Harland <kjha...@google.com>
Reply all
Reply to author
Forward
0 new messages