[M] Change in fuchsia/fuchsia[main]: [sdk][devices] Adding count field to cpu definition

4 views

Skip to first unread message

Clayton Wilkinson (Gerrit)

unread,

Sep 23, 2024, 3:17:13 PM9/23/24

to sdk-dev+a...@fuchsia.dev

Clayton Wilkinson has uploaded the change for review

Commit message

[sdk][devices] Adding count field to cpu definition

This adds a "count" field to the cpu definition in the
hardware schema. This value is used by the emulator to
configure the number of CPUs to define when running the
Fuchsia instance.

Previously, it was hardcoded to 4, so as a backwards compatibility
method, the cpu.count field defaults to 4 if it is not present when
deserializing the data.

Bug: 369114507

Change-Id: I6914c96a1598b3940aa3bc92e5f24ac736b29f33

Change diff

Change information

Files:

M build/sdk/meta/golden/hardware-f6f47515.json.golden
M build/sdk/meta/golden/virtual_device-93A41932.json.golden
M build/sdk/meta/hardware-f6f47515.json
M build/sdk/meta/src/virtual_device/v1.rs
M build/sdk/meta/virtual_device-93A41932.json
M build/sdk/virtual_device.gni
M build/virtual-devices/BUILD.gn
M src/developer/ffx/plugins/emulator/commands/show/src/lib.rs
M src/developer/ffx/plugins/emulator/configuration/src/conversions.rs
M src/developer/ffx/plugins/emulator/configuration/src/enumerations.rs
M src/developer/ffx/plugins/emulator/engines/src/show_output.rs
M src/developer/ffx/plugins/emulator/engines/templates/efi_flags.json.template
M src/developer/ffx/plugins/emulator/engines/templates/emulator_flags.json.template
M src/developer/ffx/tests/mw-goldens/goldens/emu_show.json

Change size: M

Delta: 14 files changed, 71 insertions(+), 18 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages