[M] Change in fuchsia/fuchsia[main]: [sdk] Add CPU count field to VirtualDevice

1 view
Skip to first unread message

Daniel Dougherty (Gerrit)

unread,
Jul 20, 2022, 7:40:11 PM7/20/22
to sdk-dev+a...@fuchsia.dev

Daniel Dougherty has uploaded this change for review.

View Change

[sdk] Add CPU count field to VirtualDevice

The attached bug indicates that the virtual device specification is
lacking a value for the number of CPUs needed during emulation. Up until
now, the emulator has been setting up a fixed number of CPUs, 4, based
on defaults from legacy launchers. There was no way for the user to
change this value.

This CL introduces a "count" field to the virtual device's CPU object,
adds that field to the schema, and propagates it to the emulator's
launch configuration. All associated tests are also updated for the new
schema.

Bug: 88909
Change-Id: I4937226d777387646fe07456ebb8995310593a9f
---
M build/sdk/meta/golden/virtual_device-93A41932.json.golden
M build/sdk/meta/src/metadata.rs
M build/sdk/meta/src/product_bundle_container.rs
M build/sdk/meta/src/virtual_device.rs
M build/sdk/meta/virtual_device-93A41932.json
M build/sdk/virtual_device.gni
M src/developer/ffx/lib/fms/test_data/test_virtual_device.json
M src/developer/ffx/plugins/emulator/configuration/src/conversions.rs
M src/developer/ffx/plugins/emulator/templates/emulator_flags.json.template
9 files changed, 74 insertions(+), 18 deletions(-)


To view, visit change 702528. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4937226d777387646fe07456ebb8995310593a9f
Gerrit-Change-Number: 702528
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Dougherty <dough...@google.com>
Gerrit-MessageType: newchange
Reply all
Reply to author
Forward
0 new messages