Yilong Li would like Chase Latta, Aaron Wood, Kevin Cho, CQ Bot, Andrew Davies, Hunter Freyer and Christopher Johnson to review this change.
Revert "[sdk][lacewing] Define experimental Python test element and add RTC test in IDK."
This reverts commit 264dc14daf0f922d76e36d70855cda046ca42196.
Reason for revert: Breaks core.x64 build
Original change's description:
> [sdk][lacewing] Define experimental Python test element and add RTC test in IDK.
>
> Test: Confirmed test can be bundled and run from the IDK.
>
> IDK content:
> ```
> //python
> └── rtc_conformance_test
> ├── meta.json
> └── unversioned
> ├── fidl_codec.so
> ├── fuchsia_controller_internal.so
> ├── rtc_conformance_test.pyz
> ├── ir_root
> │ ├── fuchsia.version
> │ │ └── fuchsia.version.fidl.json
> └── └── ....
> ```
>
> Size:
> ```
> 1.5M rtc_conformance_test/unversioned/fidl_codec.so
> 388K rtc_conformance_test/unversioned/rtc_conformance_test.pyz
> 6.2M rtc_conformance_test/unversioned/ir_root
> 81M rtc_conformance_test/unversioned/fuchsia_controller_internal.so
> ```
>
> * Define schema for `experiemental_python_e2e_test` SDK element
>
> * Define sdk_python_mobly_test() template for bundling new SDK element
>
> * Set `testonly` to false for all transitive targets required by RTC conformance test
>
> * Define `_no_testonly` variants of Lacewing Python libraries to work around the SDK's `assert_no_deps` restrictions on `testonly` targets as well as certain top level test group's `assert_no_deps` restriction on `e2e_test_libs` (for non-e2e tests that depend on the IDK)
>
> Change-Id: I3936b855120ec16f82cba1e01f21a2cd28c8a37f
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1002147
> Reviewed-by: Hunter Freyer <hjfr...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>
> Commit-Queue: Kevin Cho <ch...@google.com>
> Reviewed-by: Christopher Johnson <crj...@google.com>
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |