[L] Change in fuchsia/fuchsia[main]: Revert "[sdk][lacewing] Define experimental Python test element and a...
0 views
Skip to first unread message
Yilong Li (Gerrit)
Mar 25, 2024, 3:57:16 AMMar 25
to Chase Latta, Aaron Wood, Kevin Cho, CQ Bot, Andrew Davies, Hunter Freyer, Christopher Johnson, Clayton Wilkinson, Michael Shulman, Fuchsia Try Builder, Sam Hansen, Darren Chan, Megan Batty, Tricium, Pavan Kumar Juturu, Ritu Gupta, GI Roller, Yilong Li
Attention needed from Aaron Wood, Andrew Davies, Chase Latta, Christopher Johnson, Hunter Freyer and Kevin Cho
Yilong Li has uploaded the change for review![]( "Open in Gerrit")
Yilong Li would like Chase Latta, Aaron Wood, Kevin Cho, CQ Bot, Andrew Davies, Hunter Freyer and Christopher Johnson to review this change.
Commit message
Revert "[sdk][lacewing] Define experimental Python test element and add RTC test in IDK."
This reverts commit 264dc14daf0f922d76e36d70855cda046ca42196.
Reason for revert: Breaks core.x64 build
Original change's description:
> [sdk][lacewing] Define experimental Python test element and add RTC test in IDK.
>
> Test: Confirmed test can be bundled and run from the IDK.
>
> IDK content:
> ```
> //python
> └── rtc_conformance_test
> ├── meta.json
> └── unversioned
> ├── fidl_codec.so
> ├── fuchsia_controller_internal.so
> ├── rtc_conformance_test.pyz
> ├── ir_root
> │ ├── fuchsia.version
> │ │ └── fuchsia.version.fidl.json
> └── └── ....
> ```
>
> Size:
> ```
> 1.5M rtc_conformance_test/unversioned/fidl_codec.so
> 388K rtc_conformance_test/unversioned/rtc_conformance_test.pyz
> 6.2M rtc_conformance_test/unversioned/ir_root
> 81M rtc_conformance_test/unversioned/fuchsia_controller_internal.so
> ```
>
> * Define schema for `experiemental_python_e2e_test` SDK element
>
> * Define sdk_python_mobly_test() template for bundling new SDK element
>
> * Set `testonly` to false for all transitive targets required by RTC conformance test
>
> * Define `_no_testonly` variants of Lacewing Python libraries to work around the SDK's `assert_no_deps` restrictions on `testonly` targets as well as certain top level test group's `assert_no_deps` restriction on `e2e_test_libs` (for non-e2e tests that depend on the IDK)
>
> Change-Id: I3936b855120ec16f82cba1e01f21a2cd28c8a37f
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1002147
> Reviewed-by: Hunter Freyer <hjfr...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>
> Commit-Queue: Kevin Cho <ch...@google.com>
> Reviewed-by: Christopher Johnson <crj...@google.com>
Change-Id: I96dcc92b8cf398220576710d36aa28af94a893d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change diff
Change information
Files:
- M build/fidl/fidl.gni
- M build/python/BUILD.gn
- D build/python/gen_sdk_metadata_and_file_sources.py
- M build/python/python_action.gni
- M build/python/python_mobly_test.gni
- D build/python/sdk_python_mobly_test.gni
- M build/sdk/manifest_schema.json
- M build/sdk/meta/BUILD.gn
- D build/sdk/meta/experimental_python_e2e_test.json
- D build/sdk/meta/golden/experimental_python_e2e_test.json.golden
- M build/sdk/sdk_common/__init__.py
- M scripts/sdk/merger/merge.py
- M sdk/BUILD.gn
- M sdk/manifests/fuchsia_idk.manifest
- M src/developer/ffx/BUILD.gn
- M src/developer/ffx/lib/fuchsia-controller/tests/BUILD.gn
- M src/testing/end_to_end/honeydew/BUILD.gn
- M src/testing/end_to_end/mobly_base_tests/BUILD.gn
- M src/testing/end_to_end/mobly_controller/BUILD.gn
- M src/testing/end_to_end/mobly_driver/BUILD.gn
- M src/tests/end_to_end/rtc/BUILD.gn
- M third_party/mobly/BUILD.gn
Change size: L
Delta: 22 files changed, 21 insertions(+), 667 deletions(-)
Related details
Attention is currently required from:
- Aaron Wood
- Andrew Davies
- Chase Latta
- Christopher Johnson
- Hunter Freyer
- Kevin Cho
Submit Requirements:
Code-Review
Commit-Message-Has-Tags
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages