[M] Change in fuchsia/fuchsia[main]: [ffx][sdk] Separate target files in metadata

Skip to first unread message

Megan Batty (Gerrit)

May 4, 2023, 1:16:40 AM5/4/23
to sdk-dev+a...@fuchsia.dev

Megan Batty has uploaded this change for review.

View Change

[ffx][sdk] Separate target files in metadata

The earlier versions of this replicated the mistakes of the way
host_tool atoms are built by making the architecture implicit and hidden
in the path. For ffx tools, use the target_files to separate out the
architecture of the binaries.

This still builds two separate atoms for x64 and arm64, just because
the change is already quite large and that would go off into the build
system weeds but it should also support merging them into one atom
later, without causing backwards compatibility headaches.

Change-Id: If31eec50206ae8feebeb24d1a9ccda8f405f7b60
M build/sdk/meta/ffx_tool.json
M build/sdk/meta/golden/ffx_tool.json.golden
M build/sdk/meta/src/common.rs
M build/sdk/meta/src/ffx_tool.rs
M scripts/sdk/merger/merge.py
M src/developer/ffx/build/ffx_tool.gni
M src/developer/ffx/lib/sdk/src/lib.rs
M src/developer/ffx/lib/sdk/test_data/core-sdk-root/host_x64/gen/src/developer/ffx/plugins/assembly/sdk.meta.json
M src/developer/ffx/lib/sdk/test_data/core-sdk-root/sdk/manifest/core
M src/developer/ffx/lib/sdk/test_data/release-sdk-root/tools/ffx_tools/ffx-assembly-meta.json
10 files changed, 169 insertions(+), 73 deletions(-)

To view, visit change 851523. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: If31eec50206ae8feebeb24d1a9ccda8f405f7b60
Gerrit-Change-Number: 851523
Gerrit-PatchSet: 1
Gerrit-Owner: Megan Batty <mg...@google.com>
Reply all
Reply to author
0 new messages