[M] Change in fuchsia/fuchsia[main]: [idk][build] Add golden check for package metadata schema

0 views
Skip to first unread message

David Dorwin (Gerrit)

unread,
Jul 16, 2024, 2:55:40 AM7/16/24
to sdk-dev+a...@fuchsia.dev

David Dorwin has uploaded the change for review

Commit message

[idk][build] Add golden check for package metadata schema

It was missing from the list of schemas.
Bug: 352833261
Change-Id: I3880eaf2cd566b128ffc444d7de64221336d5278

Change diff

diff --git a/build/sdk/meta/BUILD.gn b/build/sdk/meta/BUILD.gn
index eabe064..124532e 100644
--- a/build/sdk/meta/BUILD.gn
+++ b/build/sdk/meta/BUILD.gn
@@ -25,6 +25,7 @@
"host_tool.json",
"loadable_module.json",
"manifest.json",
+ "package.json",
"sysroot.json",
"version_history-22rnd667.json",
"virtual_device-93A41932.json",
diff --git a/build/sdk/meta/golden/package.json.golden b/build/sdk/meta/golden/package.json.golden
new file mode 100644
index 0000000..8b37966
--- /dev/null
+++ b/build/sdk/meta/golden/package.json.golden
@@ -0,0 +1,68 @@
+{
+ "$schema": "http://json-schema.org/draft-07/schema#",
+ "description": "A Fuchsia package.",
+ "id": "http://fuchsia.com/schemas/sdk/package.json",
+ "type": "object",
+ "allOf": [
+ {
+ "$ref": "common.json#/definitions/sdk_element"
+ },
+ {
+ "additionalProperties": false,
+ "properties": {
+ "name": {
+ "description": "Name of a Fuchsia package.",
+ "type": "string"
+ },
+ "variants": {
+ "description": "List of package manifests and other files for flavors of this Fuchsia package.",
+ "items": {
+ "properties": {
+ "manifest_file": {
+ "$ref": "common.json#/definitions/file",
+ "description": "The manifest file for this package."
+ },
+ "arch": {
+ "$ref": "common.json#/definitions/target_arch",
+ "description": "The target architecture for this package."
+ },
+ "api_level": {
+ "description": "The API level this package is built against.",
+ "type": "integer"
+ },
+ "files": {
+ "$ref": "#/definitions/fileGroup",
+ "description": "Files for Fuchsia package targeting this architecture and API level."
+ }
+ },
+ "required": [
+ "manifest_file",
+ "arch",
+ "api_level"
+ ],
+ "type": "object"
+ },
+ "minItems": 1,
+ "type": "array"
+ },
+ "type": {
+ "allOf": [
+ {
+ "$ref": "common.json#/definitions/kind"
+ },
+ {
+ "enum": [
+ "package"
+ ]
+ }
+ ]
+ }
+ },
+ "required": [
+ "name",
+ "variants",
+ "type"
+ ]
+ }
+ ]
+}

Change information

Files:
  • M build/sdk/meta/BUILD.gn
  • A build/sdk/meta/golden/package.json.golden
Change size: M
Delta: 2 files changed, 69 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I3880eaf2cd566b128ffc444d7de64221336d5278
Gerrit-Change-Number: 1082027
Gerrit-PatchSet: 1
Gerrit-Owner: David Dorwin <ddo...@google.com>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages