When to move libraries to //sdk?

23 views
Skip to first unread message

Jocelyn Dang

unread,
Mar 23, 2021, 3:54:07 PM3/23/21
to sdk-dev
Hi,

If I'm planning to include a library to the SDK, should I immediately move the library to the //sdk folder? I noticed a bunch of libraries marked sdk_publishable=true outside of //sdk (example), so I wasn't sure what the general rule is

Thanks,
Jocelyn

Sean Cuff

unread,
Mar 23, 2021, 4:17:05 PM3/23/21
to Jocelyn Dang, sdk-dev
It should move if possible. SDK libraries are almost all in //sdk or //zircon -- there's three that aren't and two are only used in the experimental firmware SDK.

--
All posts must follow the Fuchsia Code of Conduct https://fuchsia.dev/fuchsia-src/CODE_OF_CONDUCT or may be removed.
---
You received this message because you are subscribed to the Google Groups "sdk-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to sdk-dev+u...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/sdk-dev/560fa36c-c791-48a7-86c0-19ae18e644d4n%40fuchsia.dev.

Adam Barth

unread,
Mar 23, 2021, 4:56:06 PM3/23/21
to Sean Cuff, Jocelyn Dang, sdk-dev
The ones in //zircon are just there because we didn't use to have a unified build.  Now that we have a unified build and can move code to where it logically makes sense, we should put all SDK libraries in //sdk/lib.  I imagine we'll clean up the ones in //zircon at some point.

Adam


Reply all
Reply to author
Forward
0 new messages