[M] Change in fuchsia/fuchsia[main]: [idk][build] api_level is always a string in IDK metadata

1 view
Skip to first unread message

David Dorwin (Gerrit)

unread,
Jul 23, 2024, 2:44:34 AM7/23/24
to sdk-dev+a...@fuchsia.dev

David Dorwin has uploaded the change for review

Commit message

[idk][build] api_level is always a string in IDK metadata

https://fxrev.dev/1082028 added support for strings while keeping
numbered API levels as integers. Based on experience with this in an
SDK, it will be simpler if the level is always a string. The value is
mostly used to build paths, so this shouldn't be a problem. Anything
that needs the integer value of a level should get them from
version_history.json.
Bug: 326277078
Change-Id: Ie728aba6787ec013a8edc9f69f159dfa5f8254fb

Change diff


Change information

Files:
  • M build/cpp/gen_sdk_prebuilt_meta_file.py
  • M build/packages/generate_sdk_package_manifest.py
  • M build/sdk/meta/cc_prebuilt_library.json
  • M build/sdk/meta/golden/cc_prebuilt_library.json.golden
  • M build/sdk/meta/golden/package.json.golden
  • M build/sdk/meta/golden/sysroot.json.golden
  • M build/sdk/meta/package.json
  • M build/sdk/meta/sysroot.json
  • M zircon/public/sysroot/sdk/BUILD.gn
Change size: M
Delta: 9 files changed, 21 insertions(+), 55 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie728aba6787ec013a8edc9f69f159dfa5f8254fb
Gerrit-Change-Number: 1087174
Gerrit-PatchSet: 1
Gerrit-Owner: David Dorwin <ddo...@google.com>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages